Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested deployments should get passed the value for parTelemetryOptOut #502

Merged
merged 6 commits into from
Apr 26, 2023

Conversation

picccard
Copy link
Contributor

@picccard picccard commented Apr 23, 2023

Overview/Summary

The orchestrator modules mgDiagSettingsAll.bicep and subPlacementAll.bicep does honor the param parTelemetryOptOut, but every nested deployment they produce does not honor it. Instead they use the default parameter-value. This results in unwanted telemetry as shown below.

This also applies to the module policyAssignmentManagementGroup.bicep, here even more telemetry is generated, as show in the second picture.

image

image

This PR fixes/adds/changes/removes

Pass the param parTelemetryOptOut to every nested module in:

  1. mgDiagSettingsAll.bicep
  2. subPlacementAll.bicep
  3. policyAssignmentManagementGroup.bicep

Breaking Changes

None

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 23, 2023
@picccard picccard changed the title mgDiagSettingsAll: pass parTelemetryOptOut to nested deployments Nested deployments should get passed the value for parTelemetryOptOut Apr 23, 2023
@jtracey93 jtracey93 added bug and removed Needs: Triage 🔍 Needs triaging by the team labels Apr 24, 2023
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @picccard for spotting this and resolving, LGTM. Will test and merge

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 4888525 into Azure:main Apr 26, 2023
@picccard picccard deleted the mgdiag-telemetryoptout branch April 29, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants