-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accelerator Documentation and remove hard-coded rg values #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0230c5a. Conflicts: accelerator/README.md
oZakari
force-pushed
the
accelerator-docs
branch
from
April 20, 2023 03:38
321e79d
to
a046208
Compare
jtracey93
reviewed
Apr 20, 2023
The lint error is because the file I am referencing is the README for the accelerator. |
jtracey93
added
enhancement
and removed
Needs: Triage 🔍
Needs triaging by the team
labels
Apr 21, 2023
jtracey93
requested changes
Apr 21, 2023
ghost
added
the
Needs: Author Feedback
label
Apr 21, 2023
ghost
removed
the
Needs: Author Feedback
label
Apr 21, 2023
oZakari
changed the title
Accelerator Documentation
Accelerator Documentation and remove hard-coded rg values
Apr 21, 2023
Added last minute adjustment to remove couple hard-coded rg names. Good spot @stalejohnsen and thanks! |
jtracey93
requested changes
Apr 22, 2023
ghost
added
the
Needs: Author Feedback
label
Apr 22, 2023
ghost
removed
the
Needs: Author Feedback
label
Apr 23, 2023
10 tasks
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
GitHub Issue: #492
ADO: AB#17187
Adds initial documentation for the ALZ Bicep Accelerator and updates consumer guide to include the Accelerator as an implementation option.
This PR fixes/adds/changes/removes
Breaking Changes
None, only updating documentation.
Testing Evidence
Not applicable as only related to documentation.
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch