Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accelerator Documentation and remove hard-coded rg values #497

Merged
merged 16 commits into from
Apr 24, 2023

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Apr 20, 2023

Overview/Summary

GitHub Issue: #492
ADO: AB#17187

Adds initial documentation for the ALZ Bicep Accelerator and updates consumer guide to include the Accelerator as an implementation option.

This PR fixes/adds/changes/removes

  1. Adds initial documentation for the ALZ Bicep Accelerator
  2. Updates consumer guide to include the Accelerator as an implementation option.
  3. Removed hardcoded rg names from PowerShell scripts and replaced with env variables

Breaking Changes

None, only updating documentation.

Testing Evidence

Not applicable as only related to documentation.

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 20, 2023
@oZakari oZakari marked this pull request as ready for review April 20, 2023 20:52
@oZakari
Copy link
Contributor Author

oZakari commented Apr 21, 2023

The lint error is because the file I am referencing is the README for the accelerator.

@jtracey93 jtracey93 added enhancement and removed Needs: Triage 🔍 Needs triaging by the team labels Apr 21, 2023
docs/wiki/Accelerator.md Outdated Show resolved Hide resolved
accelerator/README.md Outdated Show resolved Hide resolved
docs/wiki/Accelerator.md Outdated Show resolved Hide resolved
@ghost ghost removed the Needs: Author Feedback label Apr 21, 2023
@oZakari oZakari changed the title Accelerator Documentation Accelerator Documentation and remove hard-coded rg values Apr 21, 2023
@oZakari
Copy link
Contributor Author

oZakari commented Apr 21, 2023

Added last minute adjustment to remove couple hard-coded rg names. Good spot @stalejohnsen and thanks!

docs/wiki/ConsumerGuide.md Outdated Show resolved Hide resolved
@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 51f7dc7 into Azure:main Apr 24, 2023
@oZakari oZakari deleted the accelerator-docs branch June 21, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants