Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Azure / ALZ-Bicep Public

Notifications You must be signed in to change notification settings
Fork 517
Star 774

Code
Issues 19
Pull requests 1
Actions
Projects 2
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

26016 - Feature - Child Landing Zone Management Groups Flexibility #496

Merged

jtracey93 merged 38 commits into Azure:main from 4pplied:26268submggroups

Apr 19, 2023

Merged

26016 - Feature - Child Landing Zone Management Groups Flexibility #496

jtracey93 merged 38 commits into Azure:main from 4pplied:26268submggroups

Apr 19, 2023

Conversation 10 Commits 38 Checks 0 Files changed

Conversation

Copy link

Contributor

4pplied commented Apr 18, 2023 •

edited by jtracey93

Loading

Overview/Summary

Update MGDiagAll orchestration and introduction of a parameter to Management Group module that allows the deployer to true or false whether management groups beneath Platform are wanted in accordance with Trey Research architecture:

https://github.com/Azure/Enterprise-Scale/blob/main/docs/reference/treyresearch/README.md

Also add option to add additional or different child MGs beneath Platform MG via new parameter

This PR fixes/adds/changes/removes

Adds an additional parameter parPlatformMgAlzDefaultsEnable to the Management Group module. Values are either true or false whether child management groups are wanted under Platform management group, with true being default
Adds an additional parameter parPlatformMgChildren to allow additional or different child MGs to be created beneath the platform MG
Updated mgDiagsAll.bicep & subPlacementAll.bicep modules to include Platform MG and any custom child MGs under there

Breaking Changes

N/A

Testing Evidence

As part of this Pull Request I have

Read the Contribution Guide and ensured this PR is compliant with the guide
Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
Checked for duplicate Pull Requests
Associated it with relevant GitHub Issues
(ALZ Bicep Core Team Only) Associated it with relevant ADO Items
Ensured my code/branch is up-to-date with the latest changes in the main branch
Performed testing and provided evidence.
Updated one or more of the following tests (if required)
Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
If relevant, created or updated Code Tours here

Sorry, something went wrong.

All reactions

JamJarchitect and others added 30 commits

February 8, 2023 13:30


          initial push

8d4c185


          params file, useless variable, union cleanup

b57ac82


          Generate Parameter Markdowns [JamJarchitect/7b5d2d70]

2b5b85c


          Merge branch 'main' into 26268submggroups

17f8560


          children management groups

e183c30


          Generate Parameter Markdowns [JamJarchitect/f5e8dd83]

b7130e2


          mg diags


          subPlacementAll

715442e


          fix variables in diags

a45808d


          id fix

893f349


          param changes

36f2d84


          correct description decorators

ada2543


          changes

cb6c1d8


          Merge branch 'main' into 26268submggroups

2c215b1


          amendments and tested

c2d8b0f


          readmes updated. ready for review

c90afe1


          update readme

8641fe0


          update to secondary orchestration

46ee17a


          readme updated for parameter tables

ae7c7c5


          Merge branch 'main' into 26268submggroups


          Update infra-as-code/bicep/modules/managementGroups/managementGroups.…

ff5151f

…bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>


          Update infra-as-code/bicep/modules/managementGroups/managementGroups.…

4c3c29b

…bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>


          Update infra-as-code/bicep/modules/managementGroups/managementGroups.…

d8c7697

…bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>


          Update infra-as-code/bicep/orchestration/mgDiagSettingsAll/mgDiagSett…

871cfcd

…ingsAll.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>


          alz-logging

a4aaf61


          Update infra-as-code/bicep/orchestration/subPlacementAll/subPlacement…

69f7cc5

…All.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>


          Update infra-as-code/bicep/orchestration/subPlacementAll/subPlacement…

fbab168

…All.bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>


          Merge branch 'main' into 26268submggroups

19a95a5


          Generate Parameter Markdowns [JamJarchitect/1ccf0a7f]

088120f


          Merge branch 'main' into 26268submggroups

4ff1d58


          Merge branch 'main' into 26268submggroups

8d3e5d1

ghost added the Needs: Triage 🔍 Needs triaging by the team label

Copy link

Collaborator

jtracey93 commented Apr 18, 2023

/azp run validateazcloud

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Apr 18, 2023

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.

jtracey93 added enhancement and removed Needs: Triage 🔍 Needs triaging by the team labels


          Merge branch 'main' into 26268submggroups

10eecfb

Copy link

Collaborator

jtracey93 commented Apr 19, 2023

/azp run validateazcloud

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Apr 19, 2023

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.

Copy link

Collaborator

jtracey93 commented Apr 19, 2023

/azp run e2e

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Apr 19, 2023

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.

jtracey93 and others added 6 commits

April 19, 2023 09:49


          Update README.md

beb5af4


          Conditional refinement

f49cc77


          Generate Parameter Markdowns [jtracey93/f5e2d0b9]

2296b62


          Update README.md


          Update README.md

b87e1d3


          Update README.md

0edeee7

Copy link

Collaborator

jtracey93 commented Apr 19, 2023

/azp run validateazcloud

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Apr 19, 2023

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.

Copy link

Collaborator

jtracey93 commented Apr 19, 2023

/azp run e2e

All reactions

Sorry, something went wrong.

Copy link

azure-pipelines bot commented Apr 19, 2023

Azure Pipelines successfully started running 1 pipeline(s).

All reactions

Sorry, something went wrong.

jtracey93 linked an issue

that may be closed by this pull request

💡 Feature Request - Make the sub management groups under platform optional #429

Closed

jtracey93 approved these changes

View reviewed changes

jtracey93 merged commit 7da4385 into Azure:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jtracey93 jtracey93 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

💡 Feature Request - Make the sub management groups under platform optional

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.