Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameter for Alzdefaults exclusions #494

Merged
merged 9 commits into from
Apr 18, 2023
Merged

New parameter for Alzdefaults exclusions #494

merged 9 commits into from
Apr 18, 2023

Conversation

stalejohnsen
Copy link
Contributor

Overview/Summary

This PR will add flexibility to exclude specific policies from ALZ Default Policy Assignments module via the new parameter parExcludedPolicyAssignments. This will help organizations that need to deviate from some of the ALZ reference implementation policies, but at the same time wants to keep the ALZ Default Policy Assignments module as is for easier upstream updates.

This PR fixes/adds/changes/removes

  1. New parameter parExcludedPolicyAssignments in ALZ Default Policy Assignments module
  2. New wiki section in AssigningPolicies.md to describe how to use the exclusion parameter.

Breaking Changes

  1. The new parameter is optional only.

Testing Evidence

  1. First test excluding all default policy assignments
    all_excluded2
  2. Deployment success with no policy assignments
    all_excluded
  3. Second test excluding 6 specific policy assignments
    all_excluded3
  4. Deployment success with all policy assignments excluding the 6 from parameter
    all_excluded4

As part of this Pull Request I have

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit b7f9dd9 into Azure:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants