Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubNetwork: Dynamic prefix and suffix for Public IPs #493

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

picccard
Copy link
Contributor

Overview/Summary

Public IPs created in the hubNetwork module has the suffic '-PublicIP' hardcoded in the bicepfile. This PR adds support to change this suffix and/or add a prefix, such as 'pip-serviceName'

This PR fixes/adds/changes/removes

  1. adds parameter parPublicIpPrefix and parPublicIpSuffix in hubNetworking module
  2. updated the generated docs for the hubNetworking module

Breaking Changes

No breaking changes

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 16, 2023
@picccard
Copy link
Contributor Author

@microsoft-github-policy-service agree

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 added enhancement and removed Needs: Triage 🔍 Needs triaging by the team labels Apr 18, 2023
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit b958a61 into Azure:main Apr 18, 2023
@picccard picccard deleted the publicip-customname branch April 22, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants