Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

26740 - Feature - Generated Parameter Markdowns for Orchestration #466

Merged
merged 5 commits into from
Mar 22, 2023
Merged

26740 - Feature - Generated Parameter Markdowns for Orchestration #466

merged 5 commits into from
Mar 22, 2023

Conversation

4pplied
Copy link
Contributor

@4pplied 4pplied commented Mar 2, 2023

Overview/Summary

Similar functionality for to the generated markdowns for the ALZ Bicep Modules, this has now been taken to the orchestration modules.

This PR fixes/adds/changes/removes

  1. Generates markdowns in a generateddocs/ folder in each respective orchestration module
  2. Added link to the main READMEs of orchestration modules to the newly generated MDs

AB#26740

Breaking Changes

  1. N/A

Testing Evidence

image

image

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Mar 2, 2023
@4pplied
Copy link
Contributor Author

4pplied commented Mar 2, 2023

Errors due to pre-existing links to the markdowns in the respective READMEs of the orchestration and CRML folders. I will generate the initial markdowns in the PR and they can be updated accordingly in any other future PRs to resolve the checks on this PR.

@4pplied
Copy link
Contributor Author

4pplied commented Mar 2, 2023

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@4pplied 4pplied added documentation and removed Needs: Triage 🔍 Needs triaging by the team labels Mar 3, 2023
@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM awaiting tests

@jtracey93 jtracey93 merged commit 34c2013 into Azure:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants