Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Policy Library (automated) #459

Merged
merged 4 commits into from
Feb 27, 2023
Merged

Update Policy Library (automated) #459

merged 4 commits into from
Feb 27, 2023

Conversation

cae-pr-creator[bot]
Copy link
Contributor

This is an automated 'pull_request' containing updates to the library templates stored in '/infra-as-code/bicep/modules/policy/definitions/lib' & '/infra-as-code/bicep/modules/policy/assignments/lib'.
Please review the 'files changed' tab to review changes.

@ghost
Copy link

ghost commented Feb 23, 2023

Hey cae-pr-creator[bot], thanks for creating this PR.

We noticed that this PR is ammending some things related to policies (definitions or assignments) 🔍

Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules.

So it may be that this PR may be closed and we ask you to re-submit the changes to the respective code in our other repo.

However, we will review and advise further anyway but this is just a friendly premptive message and reminder of how policies are used and updated in this repo.

Thanks from your friendly msft-bot.

@ghost ghost added Area: Policy Needs: Triage 🔍 Needs triaging by the team labels Feb 23, 2023
@jtracey93
Copy link
Collaborator

@microsoft-github-policy-service agree

@jtracey93 jtracey93 added enhancement and removed Needs: Triage 🔍 Needs triaging by the team labels Feb 27, 2023
@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 marked this pull request as ready for review February 27, 2023 18:37
@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested upgrade from previous version as well, all fine

@jtracey93 jtracey93 merged commit 327bf7f into main Feb 27, 2023
@jtracey93 jtracey93 deleted the patch-policy-library branch February 27, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants