Add support to deploy an additional VWAN hub to an existing Virtual WAN #456

aarunraaj · 2023-02-22T06:39:35Z

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

AB#25157
AB#26744

This PR fixes/adds/changes/removes

Add support to deploy an additional VWAN hub to an existing Virtual WAN
Deploy VPN and ER Gateway to the additional vWAN hub
Deploy Azure firewall to the additional vWAN hub
Adds routes to the default route table for the new hub

Breaking Changes

Replace me
Replace me

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

*mulitple vWAN hub *VPN and Express route gateways on additional hubs *Azure firewall

aarunraaj · 2023-02-22T06:46:11Z

Test deployment of vWANConnectivity

jtracey93

Thanks @aarunraaj,

Looks like the build tests are failing, so please investigate and resolve that.

Aside from that can you also ensure to update the parameter files and tests in the /samples/ directory with the changes.

Finally, could you also squeeze in adding these additional properties as per the User Story AB#26744 i tagged you in as these should be quick and valuable additions, that have been requested by the community

*update parameters.all file *updated baseline.sample file * updated vWANConnectivity to include hub routing preference and router auto scale configuration provisions

aarunraaj · 2023-02-22T13:48:06Z

Thanks @aarunraaj,

Looks like the build tests are failing, so please investigate and resolve that.

Aside from that can you also ensure to update the parameter files and tests in the /samples/ directory with the changes.

Finally, could you also squeeze in adding these additional properties as per the User Story AB#26744 i tagged you in as these should be quick and valuable additions, that have been requested by the community

thanks @jtracey93 ,
Included additional properties according to AB#26744. Updated the parameters file and running final test. Will update here once done.

infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep

Added additional details about the array And expected value details for each of them.

updated mc-vwanconnecitivyt parameters min and all.json files to include the changes.

jtracey93

@aarunraaj a couple of things to sort please.

Also can you please manually generate the doc update by following https://github.com/Azure/ALZ-Bicep/wiki/Contributing#manually-generating-the-parameter-markdown-files

Thanks

infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep

*update HubRoutingPreference parameter with the default value in comment.

infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep

infra-as-code/bicep/modules/vwanConnectivity/samples/baseline.sample.bicep

infra-as-code/bicep/modules/vwanConnectivity/parameters/mc-vwanConnectivity.parameters.all.json

infra-as-code/bicep/modules/vwanConnectivity/parameters/mc-vwanConnectivity.parameters.min.json

infra-as-code/bicep/modules/vwanConnectivity/parameters/vwanConnectivity.parameters.all.json

infra-as-code/bicep/modules/vwanConnectivity/parameters/vwanConnectivity.parameters.min.json

infra-as-code/bicep/modules/vwanConnectivity/samples/baseline.sample.bicep

jtracey93 · 2023-02-28T13:12:22Z

/azp run validateazcloud

azure-pipelines · 2023-02-28T13:12:33Z

Azure Pipelines successfully started running 1 pipeline(s).

jtracey93 · 2023-02-28T13:35:16Z

/azp run e2e

azure-pipelines · 2023-02-28T13:35:26Z

Azure Pipelines successfully started running 1 pipeline(s).

jtracey93 · 2023-02-28T19:06:18Z

/azp run validateazcloud

azure-pipelines · 2023-02-28T19:06:29Z

Azure Pipelines successfully started running 1 pipeline(s).

jtracey93

LGTM

aarunraaj added 4 commits February 22, 2023 10:28

create mulitple vWAN hubs

9d51774

*mulitple vWAN hub *VPN and Express route gateways on additional hubs *Azure firewall

Merge branch 'Azure:main' into main

f753329

removed modification comments from the code

64f27d6

Merge branch 'main' of https://github.com/aarunraaj/ALZ-Bicep

ac6854c

ghost added the Needs: Triage 🔍 Needs triaging by the team label Feb 22, 2023

aarunraaj marked this pull request as ready for review February 22, 2023 06:42

removed commented lines

1b98acf

jtracey93 added enhancement and removed Needs: Triage 🔍 Needs triaging by the team labels Feb 22, 2023

jtracey93 requested changes Feb 22, 2023

View reviewed changes

ghost added the Needs: Author Feedback label Feb 22, 2023

updated baseline sample file to include the new changes

fc36e8e

ghost removed the Needs: Author Feedback label Feb 22, 2023

aarunraaj added 2 commits February 22, 2023 18:31

updated main module, baseline and parameters

b36c61f

*update parameters.all file *updated baseline.sample file * updated vWANConnectivity to include hub routing preference and router auto scale configuration provisions

updated parameters.min file

d57d4ba

jtracey93 requested changes Feb 22, 2023

View reviewed changes

ghost added the Needs: Author Feedback label Feb 22, 2023

removed comments from parameters file

74afa8f

ghost removed the Needs: Author Feedback label Feb 22, 2023

aarunraaj and others added 4 commits February 22, 2023 19:58

camelCasing updates

4d7d688

Update vwanConnectivity.parameters.min.json

872b24e

parameters file updates

e13038d

Merge branch 'main' into main

a444d6a

jtracey93 closed this Feb 23, 2023

jtracey93 reopened this Feb 23, 2023

UpdatevWAN Hub parameters decorator to include more details

5df47c7

Added additional details about the array And expected value details for each of them.

aarunraaj added 4 commits February 23, 2023 17:23

Merge branch 'main' of https://github.com/aarunraaj/ALZ-Bicep

98fa97f

updated mc-vwanConnectivity parameters min and all.json

04aa12c

updated mc-vwanconnecitivyt parameters min and all.json files to include the changes.

Update vwanConnectivity.bicep

68ca36a

Merge branch 'Azure:main' into main

a103557

jtracey93 requested changes Feb 27, 2023

View reviewed changes

infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep Outdated Show resolved Hide resolved

infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep Outdated Show resolved Hide resolved

ghost added the Needs: Author Feedback label Feb 27, 2023

Merge branch 'Azure:main' into main

be78e2a

ghost removed the Needs: Author Feedback label Feb 28, 2023

Update vwanConnectivity.bicep

21d1d1f

*update HubRoutingPreference parameter with the default value in comment.

jtracey93 requested changes Feb 28, 2023

View reviewed changes

infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep Outdated Show resolved Hide resolved

infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep Outdated Show resolved Hide resolved

ghost added the Needs: Author Feedback label Feb 28, 2023

Apply suggestions from code review

b824e78

jtracey93 requested changes Feb 28, 2023

View reviewed changes

jtracey93 and others added 2 commits February 28, 2023 11:54

Apply suggestions from code review

a50f0ce

update the markdown file

47176c8

ghost removed the Needs: Author Feedback label Feb 28, 2023

jtracey93 added 4 commits February 28, 2023 14:45

Update vwanConnectivity.bicep

ba0b95a

Update vwanConnectivity.bicep.md

1f5851a

Update vwanConnectivity.bicep.md

ac9e634

Update vwanConnectivity.bicep.md

d84a872

jtracey93 linked an issue Feb 28, 2023 that may be closed by this pull request

Azure vWAN Multiple hubs #387

Closed

jtracey93 approved these changes Feb 28, 2023

View reviewed changes

jtracey93 merged commit d9e7ed2 into Azure:main Feb 28, 2023

jtracey93 linked an issue Feb 28, 2023 that may be closed by this pull request

💡 Feature Request - Add in additional parameter for vWAN virtual hub routing preference #451

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to deploy an additional VWAN hub to an existing Virtual WAN #456

Add support to deploy an additional VWAN hub to an existing Virtual WAN #456

aarunraaj commented Feb 22, 2023 •

edited by azure-boards bot

Loading

aarunraaj commented Feb 22, 2023

jtracey93 left a comment

aarunraaj commented Feb 22, 2023 •

edited by azure-boards bot

Loading

jtracey93 left a comment

jtracey93 commented Feb 28, 2023

azure-pipelines bot commented Feb 28, 2023

jtracey93 commented Feb 28, 2023

azure-pipelines bot commented Feb 28, 2023

jtracey93 commented Feb 28, 2023

azure-pipelines bot commented Feb 28, 2023

jtracey93 left a comment

Add support to deploy an additional VWAN hub to an existing Virtual WAN #456

Add support to deploy an additional VWAN hub to an existing Virtual WAN #456

Conversation

aarunraaj commented Feb 22, 2023 • edited by azure-boards bot Loading

Overview/Summary

This PR fixes/adds/changes/removes

Breaking Changes

Testing Evidence

As part of this Pull Request I have

aarunraaj commented Feb 22, 2023

jtracey93 left a comment

Choose a reason for hiding this comment

aarunraaj commented Feb 22, 2023 • edited by azure-boards bot Loading

jtracey93 left a comment

Choose a reason for hiding this comment

jtracey93 commented Feb 28, 2023

azure-pipelines bot commented Feb 28, 2023

jtracey93 commented Feb 28, 2023

azure-pipelines bot commented Feb 28, 2023

jtracey93 commented Feb 28, 2023

azure-pipelines bot commented Feb 28, 2023

jtracey93 left a comment

Choose a reason for hiding this comment

aarunraaj commented Feb 22, 2023 •

edited by azure-boards bot

Loading

aarunraaj commented Feb 22, 2023 •

edited by azure-boards bot

Loading