Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update containerRegistry API version #440

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

bartlannoeye
Copy link
Contributor

Overview/Summary

Addendum for #247

Updated ACR API version from preview to the latest stable as it was giving a deploy error.

/home/vsts/work/1/s/infra-as-code/bicep/CRML/containerRegistry/containerRegistry.bicep(29,76) : Error use-recent-api-versions: Use more recent API version for 'Microsoft.ContainerRegistry/registries'. '2022-02-01-preview' is a preview version and there is a more recent non-preview version available. Acceptable versions: 2023-01-01-preview, 2022-12-01, 2021-09-01 [https://aka.ms/bicep/linter/use-recent-api-versions]
/home/vsts/work/1/s/infra-as-code/bicep/orchestration/governanceacr/governanceacr.bicep(34,34) : Error BCP104: The referenced module has errors.
##[error]Script failed with exit code: 1

This PR fixes/adds/changes/removes

  1. containerRegistry API version

Testing Evidence

image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Feb 2, 2023
@jtracey93 jtracey93 added bug and removed Needs: Triage 🔍 Needs triaging by the team labels Feb 2, 2023
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bartlannoeye again for this.

Fancy also doing the same for Microsoft.Network/virtualNetworkGateways in the hubNetworking module as your tests on this PR are failing due to this also.

Let me know 👍

@bartlannoeye
Copy link
Contributor Author

@jtracey93 I had a quick look at the error, looks like my network deployment on Tuesday was just in time :). I'll update the templates and let the tests have another go at it here.

'2021-02-01' is 731 days old, should be no more than 730 days old

@ghost ghost removed the Needs: Author Feedback label Feb 2, 2023
@jtracey93 jtracey93 closed this Feb 2, 2023
@jtracey93 jtracey93 reopened this Feb 2, 2023
@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 self-assigned this Feb 2, 2023
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 7b5d2d7 into Azure:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants