Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added parAutomationAccountUseManagedIdentity parameter #433

Merged

Conversation

mbrat2005
Copy link
Contributor

@mbrat2005 mbrat2005 commented Jan 20, 2023

Overview/Summary

AB#25134

Adds default configuration to assign a managed system identity to the deployed automation account, in order to pass the associated PSRule test.

This PR fixes/adds/changes/removes

  1. Adds parameter parAutomationAccountUseManagedIdentity with default value of 'true', so that the Automation Account will have a managed identity assigned by default. Updates related module parameter files.

Breaking Changes

Testing Evidence

Tested template logging.bicep with param file logging.parameters.all.json, confirmed deployed AA had managed identity. Tested with same, but adding -p parAutomationAccountUseManagedIdentity=false, confirmed that AA did not have an identity.

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Jan 20, 2023
@mbrat2005 mbrat2005 marked this pull request as ready for review January 20, 2023 20:38
@jtracey93 jtracey93 self-assigned this Jan 26, 2023
@jtracey93 jtracey93 self-requested a review January 26, 2023 16:05
@jtracey93 jtracey93 added enhancement and removed Needs: Triage 🔍 Needs triaging by the team labels Jan 26, 2023
@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 9ed6f47 into Azure:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants