-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Generated Values in _policyAssignmentsBicepInput.txt are incorrect #427
Bug: Generated Values in _policyAssignmentsBicepInput.txt are incorrect #427
Conversation
Hey mbrat2005, thanks for creating this PR. We noticed that this PR is ammending some things related to policies (definitions or assignments) 🔍 Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules. So it may be that this PR may be closed and we ask you to re-submit the changes to the respective code in our other repo. However, we will review and advise further anyway but this is just a friendly premptive message and reminder of how policies are used and updated in this repo. Thanks from your friendly msft-bot. |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mbrat2005 LGTM 🚢
Overview/Summary
Generated Values in _policyAssignmentsBicepInput.txt are incorrect #426 AB#25950
This PR fixes/adds/changes/removes
modManagementGroups.outputs.outTopLevelMGId
withvarTopLevelManagementGroupResourceId
in the policy assignment files ininfra-as-code/bicep/modules/policy/assignments/lib/china/policy_assignments/
Breaking Changes
Testing Evidence
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch