Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Generated Values in _policyAssignmentsBicepInput.txt are incorrect #427

Merged
merged 7 commits into from
Jan 20, 2023

Conversation

mbrat2005
Copy link
Contributor

@mbrat2005 mbrat2005 commented Jan 6, 2023

Overview/Summary

Generated Values in _policyAssignmentsBicepInput.txt are incorrect #426 AB#25950

This PR fixes/adds/changes/removes

  1. Update the loadJsonContent path depth for both Invoke-PolicyToBicep.ps1 and Invoke-PolicyToBicep-China.ps1 scripts
  2. Replaces modManagementGroups.outputs.outTopLevelMGId with varTopLevelManagementGroupResourceId in the policy assignment files in infra-as-code/bicep/modules/policy/assignments/lib/china/policy_assignments/

Breaking Changes

Testing Evidence

image

image

As part of this Pull Request I have

@ghost
Copy link

ghost commented Jan 6, 2023

Hey mbrat2005, thanks for creating this PR.

We noticed that this PR is ammending some things related to policies (definitions or assignments) 🔍

Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules.

So it may be that this PR may be closed and we ask you to re-submit the changes to the respective code in our other repo.

However, we will review and advise further anyway but this is just a friendly premptive message and reminder of how policies are used and updated in this repo.

Thanks from your friendly msft-bot.

@ghost ghost added Area: Policy Needs: Triage 🔍 Needs triaging by the team labels Jan 6, 2023
@mbrat2005 mbrat2005 marked this pull request as ready for review January 9, 2023 15:02
@jtracey93
Copy link
Collaborator

jtracey93 commented Jan 19, 2023

AB#25950

@jtracey93 jtracey93 self-assigned this Jan 20, 2023
@jtracey93 jtracey93 self-requested a review January 20, 2023 17:26
@jtracey93 jtracey93 added bug and removed Needs: Triage 🔍 Needs triaging by the team labels Jan 20, 2023
@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 linked an issue Jan 20, 2023 that may be closed by this pull request
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mbrat2005 LGTM 🚢

@jtracey93 jtracey93 merged commit 38a5994 into Azure:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - PolicyAssignment lib generating wrong name/paths
2 participants