Issue #416 - Link description in policy definitions for China

[4pplied]

Overview/Summary

Replaced link description as duplicate commercial cloud instead of one commercial, one for china

This PR fixes/adds/changes/removes

1. Link definition in policy definitions module readme to go to mooncake parameters.
2. Fixes 🪲 Bug - Incorrect link description in Wiki page for Policy Definitions #416 & AB#25662

Breaking Changes

1. N/A

Testing Evidence

N/A

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• Checked for duplicate Pull Requests
• Associated it with relevant GitHub Issues
• (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated one or more of the following tests (if required)
  • Unit
  • Linting
  • E2E (End-To-End)
  • ValidateAzCloud (Base validation in Azure Cloud)
  • ValidateMcCloud (Base validation in Azure China Cloud)
• Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
• If relevant, created or updated Code Tours here

[jfaurskov]

LGTM

[jtracey93]

Thanks @JamJarchitect I found a couple of other instances of this bug to change:

• https://github.com/Azure/ALZ-Bicep/blob/main/infra-as-code/bicep/modules/roleAssignments/README.md
• https://github.com/Azure/ALZ-Bicep/blob/main/infra-as-code/bicep/modules/policy/assignments/alzDefaults/README.md

[4pplied]

Thanks @JamJarchitect I found a couple of other instances of this bug to change:

• https://github.com/Azure/ALZ-Bicep/blob/main/infra-as-code/bicep/modules/roleAssignments/README.md
• https://github.com/Azure/ALZ-Bicep/blob/main/infra-as-code/bicep/modules/policy/assignments/alzDefaults/README.md

Now it get's interesting!

• roleAssignments uses the same Bicep module for both Commercial and China from the looks of things. I will amend the parameter link to say `Link to parameters' or something to that effect with mentioning default Mooncake parameters.
• The policy/assignments/alzDefaults has parameter files for china, but not a separate module. I'll do the same as above and mention that default Mooncake parameters are available too.

Thoughts @jtracey93 ?

[4pplied]

Thanks @JamJarchitect I found a couple of other instances of this bug to change:

• https://github.com/Azure/ALZ-Bicep/blob/main/infra-as-code/bicep/modules/roleAssignments/README.md
• https://github.com/Azure/ALZ-Bicep/blob/main/infra-as-code/bicep/modules/policy/assignments/alzDefaults/README.md

Now it get's interesting!

• roleAssignments uses the same Bicep module for both Commercial and China from the looks of things. I will amend the parameter link to say `Link to parameters' or something to that effect with mentioning default Mooncake parameters.
• The policy/assignments/alzDefaults has parameter files for china, but not a separate module. I'll do the same as above and mention that default Mooncake parameters are available too.

Thoughts @jtracey93 ?

Separate module for Mooncake exists mc-alzDefaultPolicyAssignments so I've amended the parameter link description to reflect accordingly!

[jtracey93]

@JamJarchitect is this good for re-review?

[4pplied]

@JamJarchitect is this good for re-review?

I'm just debating a last couple of bits.

I'm think to put a note in each of the parameters section just stating that the module CAN be used in Mooncake, but there is no dedicated module for it, but we have example parameters in the folder - it'll just clear up any confusion.

Thoughts?

[jtracey93]

Sounds good

[4pplied]

Sounds good

Should be ready for review now. Updated the links to the markdowns appropriately and put a note in about the modules and Azure China

[4pplied]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jtracey93]

LGTM

[jtracey93]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).