Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #386 & #330 #398

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Nov 24, 2022

Overview/Summary

Resolve #386 & #330

This PR fixes/adds/changes/removes

  1. Fixes Update policy assignment for deny public IP #386 by replacing custom with built-in assignment in both Public & China
  2. Fixes Review and update private DNS zones for private endpoint #330 by updating all Private DNS Zones with all the latest available for Public

Breaking Changes

Old policy assignment for Deny-Public-IP will need manually removing from the following scopes: corp (incorrect assignment) and identity. New policy assigned with name of Deny-Public-IP-Addresses (so technically not a breaking change, just a clean-up task)

Testing Evidence

Linting and automated tests will suffice

As part of this Pull Request I have

@ghost

This comment was marked as off-topic.

@ghost ghost added Area: Policy Needs: Triage 🔍 Needs triaging by the team labels Nov 24, 2022
@jtracey93 jtracey93 added Area: Networking and removed Needs: Triage 🔍 Needs triaging by the team labels Nov 24, 2022
@jtracey93 jtracey93 requested a review from jfaurskov November 24, 2022 20:14
@jtracey93
Copy link
Collaborator Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfaurskov
Copy link
Contributor

/azp run validatemccloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if validatemccloud succeeds :-)

@jtracey93 jtracey93 merged commit 6f80c5c into Azure:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update policy assignment for deny public IP Review and update private DNS zones for private endpoint
2 participants