Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update role ID and name #379

Merged
merged 5 commits into from
Nov 7, 2022
Merged

fix: Update role ID and name #379

merged 5 commits into from
Nov 7, 2022

Conversation

DaFitRobsta
Copy link
Contributor

@DaFitRobsta DaFitRobsta commented Nov 7, 2022 •
edited
Loading

Overview/Summary

Updated the custom role modules to provide a unique GUID for its ID which includes the management group name. Also updated the name of the custom role to include management group name too. For example: [alz] Subscription owner.
Bug Fix: #362

This PR fixes/adds/changes/removes

  1. Bug fix: 🪲 Bug Report - Custom roles deployments on canary management group conflict #362

Breaking Changes

  1. For existing deployments, if one uses the updated modules, it will create a new custom RBAC role based on the naming convention mentioned above.

Testing Evidence

Deployed custom role modules in Azure Commercial to two separate Management Groups at the same level. Both deployments were successful following this pattern:
image

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Nov 7, 2022
@DaFitRobsta DaFitRobsta marked this pull request as ready for review November 7, 2022 18:49
jtracey93
jtracey93 requested changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the README.md and the screenshot, also add a note around why we are doing this for uniqueness within the same AAD Tenant

Cheers

@ghost ghost removed the Needs: Author Feedback label Nov 7, 2022
@jtracey93 jtracey93 self-requested a review November 7, 2022 20:47
@jtracey93 jtracey93 added Area: RBAC and removed Needs: Triage 🔍 Needs triaging by the team labels Nov 7, 2022
@jtracey93 jtracey93 self-assigned this Nov 7, 2022
@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jtracey93
jtracey93 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 7449e01 into Azure:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees

@jtracey93 jtracey93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - Custom roles deployments on canary management group conflict
2 participants
@DaFitRobsta @jtracey93