Change deployment scope for MG Diagnostics #338

[lachaves]

Overview/Summary

This PR changes the scope of the orchestration module mgDiagSettingsAll from tenant to mg level.

This PR fixes Issue #338

Breaking Changes

None

Testing Evidence

The validation available here https://learn.microsoft.com/en-us/rest/api/monitor/management-group-diagnostic-settings/get?tabs=HTTP&tryIt=true&source=docs#code-try-0 was used to test.

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• [ X] Checked for duplicate Pull Requests
• [ X] Associated it with relevant GitHub Issues
• (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• [X ] Performed testing and provided evidence.
• Updated one or more of the following tests (if required)
  • Unit
  • Linting
  • E2E (End-To-End)
  • ValidateAzCloud (Base validation in Azure Cloud)
  • ValidateMcCloud (Base validation in Azure China Cloud)
• Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
• If relevant, created or updated Code Tours here

As part of this Pull Request I have

• Read the Contribution Guide and ensured this PR is compliant with the guide
• Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• [ X] Checked for duplicate Pull Requests
• [ X] Associated it with relevant GitHub Issues
• (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• [X ] Performed testing and provided evidence.
• Updated one or more of the following tests (if required)
  • Unit
  • Linting
  • E2E (End-To-End)
  • ValidateAzCloud (Base validation in Azure Cloud)
  • ValidateMcCloud (Base validation in Azure China Cloud)
• Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
• If relevant, created or updated Code Tours here

[jtracey93]

Thanks @lachaves for your work here. A couple of small suggestions plus the below:

Make updates to the tests here:

1. https://github.com/Azure/ALZ-Bicep/blob/main/tests/pipelines/base-unit-validate.yml#L108
2. https://github.com/Azure/ALZ-Bicep/blob/main/tests/pipelines/bicep-build-to-validate.yml#L197
3. https://github.com/Azure/ALZ-Bicep/blob/main/tests/pipelines/mc-base-unit-validate.yml#L88

Thanks and let me know when good to review again 👍

[lachaves]

@jtracey93, Thanks for your review, suggestions and updates completed. Please validate and let me know if anything still missing.

[jtracey93]

/azp run validateazcloud

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jtracey93]

/azp run e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jtracey93]

LGTM

[coolhome]

@jtracey93 I think this is incorrect, it should be an array like the JSON example? The description also is incorrect for the field, its not a dictionary object but a array of strings.

[jtracey93]

@lachaves to comment

[lachaves]

@coolhome @jtracey93 , reviewing right now, will update documentation as required.

[lachaves]

I have changed the description in the parameters table and also the bicep example for the parameter to show as an array type. Sending a PR with updates.