Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata filtering to China .github/scripts/Invoke-PolicyToBicep-China.ps1 #369

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Nov 1, 2022

Overview/Summary

Add metadata filtering to China .github/scripts/Invoke-PolicyToBicep-China.ps1

This PR fixes/adds/changes/removes

  1. Part of fix for Bug Report - Unable to deploy Azure China Policy Definitions due to addition of 'Deploy-Budget' Definition #365

Breaking Changes

None

Testing Evidence

Tested locally and had desired results.
image

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Nov 1, 2022
@jtracey93 jtracey93 requested a review from jfaurskov November 1, 2022 17:11
@jtracey93 jtracey93 added bug and removed Needs: Triage 🔍 Needs triaging by the team bug labels Nov 1, 2022
@jtracey93
Copy link
Collaborator Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfaurskov jfaurskov merged commit e0ea90b into Azure:main Nov 2, 2022
@jtracey93 jtracey93 deleted the improve-china-policy-filtering branch November 2, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants