Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for groups as part of policy Initiatives #364

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

vedagudipati
Copy link
Contributor

Overview/Summary

Support for groups as part of policy Initiatives. The changes are to support the issue detailed here - #357

This PR fixes/adds/changes/removes

  1. Updated the Invoke-PolicyToBicep.ps1 PowerShell script for generating groups as part of the varCustomPolicySetDefinitionsArray
  2. Updated the invocation of policySetDefinitions creation to include group names

Breaking Changes

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have executed the Invoke-PolicyToBicep.ps1 PowerShell to ensure it runs successfully.

1. Updated the Invoke-PolicyToBicep.ps1 PowerShell script for generating groups as part of the varCustomPolicySetDefinitionsArray
2. updated the invocation of policySetDefinitions creation to include group names
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Oct 28, 2022
@jtracey93 jtracey93 added Area: Policy and removed Needs: Triage 🔍 Needs triaging by the team labels Oct 29, 2022
@jtracey93 jtracey93 self-assigned this Oct 29, 2022
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vedagudipati,

Thanks for this. A couple of things please:

  • Can you add the same for the china/mooncake versions of the script and definitions module?
  • Can we rename groups to definitionGroups in the output to the txt file and therefore update its reference usage in the module

Thanks and let me know if any questions

Thanks

Jack

1) Added code in Invoke-PolicyToBicep-China.ps1 to support mooncake deployment
2) Addressed the PR comments with regards to naming
@ghost ghost removed the Needs: Author Feedback label Oct 31, 2022
@vedagudipati
Copy link
Contributor Author

Hey @vedagudipati,

Thanks for this. A couple of things please:

  • Can you add the same for the china/mooncake versions of the script and definitions module?
  • Can we rename groups to definitionGroups in the output to the txt file and therefore update its reference usage in the module

Thanks and let me know if any questions

Thanks

Jack

Hi @jtracey93,

Made the changes based on your review comments. Please take a look and let me know if there are any additional changes needed.

Thanks,
Veda.

@jtracey93
Copy link
Collaborator

Tested locally and validation pipeline test not required here as no module changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Feature Request - Add support for groups in a policy initiative
2 participants