-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidance Update - Policies to Built-In #363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtracey93
requested changes
Oct 30, 2022
/azp run ValidateAzCloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run ValidateAzCloud |
Azure Pipelines successfully started running 1 pipeline(s). |
jtracey93
added
documentation
and removed
Needs: Triage 🔍
Needs triaging by the team
labels
Nov 1, 2022
jtracey93
requested changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work mate, just a few things:
- Can you update the AzAdvertizer image on this page as you are touching it? With the latest image from here: https://github.com/Azure/Enterprise-Scale/blob/main/docs/ESLZ-Policies.md#azadvertizer-integration
ghost
added
the
Needs: Author Feedback
label
Nov 1, 2022
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
ghost
removed
the
Needs: Author Feedback
label
Nov 1, 2022
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
/azp run ValidateAzCloud |
Azure Pipelines successfully started running 1 pipeline(s). |
jtracey93
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Update to policy deep dive to provide more details on how to update from ALZ custom policies to Azure Built-in policies.
This PR fixes/adds/changes/removes
Breaking Changes
N/A
Testing Evidence
No testing done since this is solely documentation.
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch