Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance Update - Policies to Built-In #363

Merged
merged 11 commits into from
Nov 2, 2022

Conversation

jfaurskov
Copy link
Contributor

Overview/Summary

Update to policy deep dive to provide more details on how to update from ALZ custom policies to Azure Built-in policies.

This PR fixes/adds/changes/removes

  1. Updates PolicyDeepDive.md with sections on how to migrate from custom ALZ to Built-in
  2. Adds a number of supplemental pngs for clarit

Breaking Changes

N/A

Testing Evidence

No testing done since this is solely documentation.

As part of this Pull Request I have

@jfaurskov jfaurskov requested a review from jtracey93 October 27, 2022 18:09
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Oct 27, 2022
@jtracey93 jtracey93 changed the title Push update Guidance Update - Policies to Built-In Oct 27, 2022
docs/wiki/PolicyDeepDive.md Outdated Show resolved Hide resolved
docs/wiki/PolicyDeepDive.md Outdated Show resolved Hide resolved
docs/wiki/PolicyDeepDive.md Outdated Show resolved Hide resolved
docs/wiki/PolicyDeepDive.md Outdated Show resolved Hide resolved
docs/wiki/PolicyDeepDive.md Outdated Show resolved Hide resolved
docs/wiki/PolicyDeepDive.md Show resolved Hide resolved
docs/wiki/PolicyDeepDive.md Outdated Show resolved Hide resolved
docs/wiki/PolicyDeepDive.md Outdated Show resolved Hide resolved
@jfaurskov jfaurskov requested a review from jtracey93 October 31, 2022 12:29
@jfaurskov
Copy link
Contributor Author

/azp run ValidateAzCloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfaurskov
Copy link
Contributor Author

/azp run ValidateAzCloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 added documentation and removed Needs: Triage 🔍 Needs triaging by the team labels Nov 1, 2022
@jtracey93 jtracey93 self-assigned this Nov 1, 2022
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work mate, just a few things:

  1. Can you update the AzAdvertizer image on this page as you are touching it? With the latest image from here: https://github.com/Azure/Enterprise-Scale/blob/main/docs/ESLZ-Policies.md#azadvertizer-integration

docs/wiki/PolicyDeepDive.md Outdated Show resolved Hide resolved
docs/wiki/PolicyDeepDive.md Outdated Show resolved Hide resolved
docs/wiki/PolicyDeepDive.md Outdated Show resolved Hide resolved
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
@ghost ghost removed the Needs: Author Feedback label Nov 1, 2022
jfaurskov and others added 3 commits November 1, 2022 16:12
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
@jfaurskov
Copy link
Contributor Author

/azp run ValidateAzCloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 self-requested a review November 2, 2022 10:19
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 5e3742b into Azure:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants