Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Policy Library for Azure China (automated) #361

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

github-actions[bot]
Copy link
Contributor

This is an automated 'pull_request' containing updates to the library templates stored in '/infra-as-code/bicep/modules/policy/definitions/lib/china' & '/infra-as-code/bicep/modules/policy/assignments/lib'.
Please review the 'files changed' tab to review changes.

@ghost
Copy link

ghost commented Oct 26, 2022

Hey github-actions[bot], thanks for creating this PR.

We noticed that this PR is ammending some things related to policies (definitions or assignments) 🔍

Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules.

So it may be that this PR may be closed and we ask you to re-submit the changes to the respective code in our other repo.

However, we will review and advise further anyway but this is just a friendly premptive message and reminder of how policies are used and updated in this repo.

Thanks from your friendly msft-bot.

@ghost ghost added Area: Policy Needs: Triage 🔍 Needs triaging by the team labels Oct 26, 2022
@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label Oct 27, 2022
@jtracey93 jtracey93 self-requested a review October 27, 2022 13:52
@jtracey93 jtracey93 marked this pull request as ready for review October 27, 2022 13:52
@jtracey93 jtracey93 merged commit 245957d into main Oct 27, 2022
@jtracey93 jtracey93 deleted the patch-policy-library-china branch October 27, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants