Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16989: Add bicep sample code #355

Merged
merged 6 commits into from
Nov 14, 2022

Conversation

khushal08
Copy link
Contributor

@khushal08 khushal08 commented Oct 25, 2022

Overview/Summary

Sample bicep code to run different modules.

This PR fixes/adds/changes/removes

  1. Provides an example using bicep to run a particular module.

Breaking Changes

  1. None

Testing Evidence

  1. Tested locally by deploying the code.
  2. Tested PSRule to make sure that the pre-deployment checks pass.

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Oct 25, 2022
@khushal08
Copy link
Contributor Author

@jtracey93 Can you please review? thanks

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @khushal08,

Looks like some issues we either need to fix in this PR or create separate issues for to then fix post merging this PR: https://github.com/Azure/ALZ-Bicep/actions/runs/3317756169

Let me know which way you want to go as I this is part of the feature work you have assigned.

Cheers

Jack

@ghost
Copy link

ghost commented Nov 2, 2022

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@jtracey93
Copy link
Collaborator

still active

@jtracey93 jtracey93 added enhancement and removed Needs: Triage 🔍 Needs triaging by the team labels Nov 2, 2022
@ghost
Copy link

ghost commented Nov 10, 2022

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@jtracey93
Copy link
Collaborator

Still active

@khushal08 khushal08 force-pushed the 16989-bicep-module-usage branch from 6ee9660 to d07db88 Compare November 11, 2022 02:55
@ghost ghost removed the Needs: Author Feedback label Nov 11, 2022
Covered by DINE policy.

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants