Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Added subnet disclaimer #322

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

DaFitRobsta
Copy link
Contributor

@DaFitRobsta DaFitRobsta commented Sep 29, 2022

Overview/Summary

Added a disclaimer about the spokeNetworking.bicep module and how it deploys a blank vNet. Also included guidance for utilizing CARML or other techniques for supporting subnet declaration.

This PR fixes/adds/changes/removes

  1. Closes ❓👂 Question/Feedback - Add subnets for vNet creation in modules #301

Breaking Changes

  1. Only updating readme.md file

Testing Evidence

Only textual changes

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Sep 29, 2022
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit faa03df into Azure:main Sep 30, 2022
@DaFitRobsta DaFitRobsta deleted the spokeNetworking-Explaination branch September 30, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Needs triaging by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

❓👂 Question/Feedback - Add subnets for vNet creation in modules
2 participants