Management Group Diagnostic Settings Enablement - New Module #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 28, 2022 09:06
ghost
added
the
jtracey93
changed the title
|
Hey @lachaves, Could you please edit and fill in the PR template for this PR? |
…icep into mgdiagnostictoLAW
|
@jtracey93 Ready for review |
jtracey93
added
Area: Management Groups
and removed
Needs: Triage 🔍
jtracey93
requested changes
Sep 30, 2022
There was a problem hiding this comment.
Nice work @lachaves have left a number of comments and suggestions, ping me on Teams if any questions but hopefully most of it is self-explanatory 👍
On top of the comments on the code and files here are some other bits:
- Can you add parameters folders and files to the
mgDiagSettingsmodule directory for consistency across all modules - Can you add to each of the ADO Pipelines here that we use for testing: https://github.com/Azure/ALZ-Bicep/tree/main/tests/pipelines
- Reach out to me or @jfaurskov if you have any questions around the conditional logic we use for the
bicep-build-to-validate.ymlormc-base-unit-validate.yml
- Reach out to me or @jfaurskov if you have any questions around the conditional logic we use for the
Thanks again and looking forward to seeing the comments adressed and then we can test and merge. 👍
infra-as-code/bicep/orchestration/mgDiagSettingsAll/mgDiagSettingsAll.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/orchestration/mgDiagSettingsAll/mgDiagSettingsAll.bicep
Outdated
Show resolved
Hide resolved
...-code/bicep/orchestration/mgDiagSettingsAll/parameters/mgDiagSettingsAll.parameters.all.json
Outdated
Show resolved
Hide resolved
...-code/bicep/orchestration/mgDiagSettingsAll/parameters/mgDiagSettingsAll.parameters.all.json
Outdated
Show resolved
Hide resolved
...-code/bicep/orchestration/mgDiagSettingsAll/parameters/mgDiagSettingsAll.parameters.min.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run validateazcloud |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run e2e |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run validateazcloud |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Merging new module addition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
New module under orchestration folder that calls another new module to enable Diagnostic Settings for Management Groups inthe ALZ Management Group Hierarchy.
This PR fixes/adds/changes/removes
Breaking Changes
NA
Testing Evidence
Validated with several deployments
Validated using https://learn.microsoft.com/en-us/rest/api/monitor/management-group-diagnostic-settings/get?tabs=HTTP&tryIt=true&source=docs#code-try-0
As part of this Pull Request I have
.bicepfile/s I am adding/editing are using the latest API version possiblemainbranch