Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bicepconfig.json linter update #318

Merged
merged 16 commits into from
Sep 20, 2022
Merged

chore: bicepconfig.json linter update #318

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f2ad1c9
doc: PE and wiki, linter
DaFitRobsta Sep 13, 2022
5bb85a4
fix: updated workflow for b.json
DaFitRobsta Sep 13, 2022
cb840fd
chore: update linter rules to latest available
DaFitRobsta Sep 13, 2022
81c44d4
add bicep installed version output
jtracey93 Sep 15, 2022
84bd183
helps if you get the bicep version
jtracey93 Sep 15, 2022
d11f514
add step to install latest bicep
jtracey93 Sep 15, 2022
4d1a828
update step name
jtracey93 Sep 15, 2022
51bd23c
fix: updated API to latest preview
DaFitRobsta Sep 15, 2022
7b23e72
fix: throw exception after processing all files
DaFitRobsta Sep 16, 2022
778dda3
fix: declare $output outside of foreach loop
DaFitRobsta Sep 16, 2022
d7dcd16
fix: added bicep path for get-childitem
DaFitRobsta Sep 16, 2022
8f7a460
revert: removed -Path parameter
DaFitRobsta Sep 16, 2022
e33f5c5
fix: customRoles API version
DaFitRobsta Sep 16, 2022
ffe0be9
fix: typo, missing $
DaFitRobsta Sep 16, 2022
36ccd78
fix: Adjusting output if no error
DaFitRobsta Sep 16, 2022
338c7d0
fix: linter findings - resolved
DaFitRobsta Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/bicep-build-to-validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
- "**.bicep"
- "ps-rule.yaml"
- ".ps-rule/*"
- "**/bicepconfig.json"
workflow_dispatch: {}

jobs:
Expand Down
25 changes: 25 additions & 0 deletions docs/wiki/Contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- [Bicep Best Practices](#bicep-best-practices)
- [Bicep Code Styling](#bicep-code-styling)
- [Bicep Elements Naming Standards](#bicep-elements-naming-standards)
- [Bicep Common Parameters Naming Standards](#bicep-common-parameters-naming-standards)
- [Bicep File Structure](#bicep-file-structure)
- [Bicep File Structure Example](#bicep-file-structure-example)
- [Constructing a Bicep Module](#constructing-a-bicep-module)
Expand Down Expand Up @@ -230,6 +231,30 @@ To author Bicep modules that are in-line with the requirements for this project,
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions infra-as-code/bicep/CRML/containerRegistry/bicepconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,30 @@
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions infra-as-code/bicep/CRML/customerUsageAttribution/bicepconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,30 @@
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions infra-as-code/bicep/CRML/subscriptionAlias/bicepconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,30 @@
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions infra-as-code/bicep/modules/customRoleDefinitions/bicepconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,30 @@
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions infra-as-code/bicep/modules/hubNetworking/bicepconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,30 @@
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions infra-as-code/bicep/modules/logging/bicepconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,30 @@
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions infra-as-code/bicep/modules/managementGroups/bicepconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,30 @@
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions infra-as-code/bicep/modules/policy/assignments/alzDefaults/bicepconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,30 @@
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions infra-as-code/bicep/modules/policy/assignments/bicepconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,30 @@
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions infra-as-code/bicep/modules/policy/definitions/bicepconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,30 @@
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
24 changes: 24 additions & 0 deletions infra-as-code/bicep/modules/privateDnsZones/bicepconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,30 @@
},
"max-variables": {
"level": "error"
},
"artifacts-parameters":{
"level": "error"
},
"no-unused-existing-resources":{
"level": "error"
},
"prefer-unquoted-property-names":{
"level": "error"
},
"secure-params-in-nested-deploy":{
"level": "error"
},
"secure-secrets-in-params":{
"level": "error"
},
"use-recent-api-versions":{
"level": "error"
},
"use-resource-id-functions":{
"level": "error"
},
"use-stable-resource-identifiers":{
"level": "error"
}
}
}
Expand Down
Loading