Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Orchestration Module: subPlacementAll #298

Merged
merged 9 commits into from
Aug 1, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Jul 31, 2022

Overview/Summary

Add new orchestration module called subPlacementAll as per request in #295

This PR fixes/adds/changes/removes

  1. Add new orchestration module called subPlacementAll as per request in 💡 Feature Request - Subscription ID placement in Management Groups #295
  2. Closes 💡 Feature Request - Subscription ID placement in Management Groups #295

Breaking Changes

None

Testing Evidence

Automated testing should suffice.

image

As part of this Pull Request I have

@jtracey93
Copy link
Collaborator Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator Author

Tests all passing and added screenshot to show sub placement working using new orchestration module (as now used in test framework on this PR).

Markdown links failing as module doesn't exist in main branch yet but does in this PR 👍

@jfaurskov
Copy link
Contributor

/azp run validatemccloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @jtracey93. A couple of comments. Also I started the mc validate pipeline too.

Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 29139a6 into Azure:main Aug 1, 2022
@jtracey93 jtracey93 deleted the orch-mod-sub-placement-all branch August 1, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Needs triaging by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Feature Request - Subscription ID placement in Management Groups
2 participants