-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest API versions in all modules #293
Conversation
/azp run validate az cloud |
No pipelines are associated with this pull request. |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
oh, I totally forgot that those Azure Pipelines are not public. |
Hey @olljanat, yup just one of those things im afraid due to the way GitHub handles secrets in PRs from Forks. The errors were mainly vwan DNS Zone related, so nothing you did but something your bigger change forced a run of the entire pipeline and highlighted. I have made some changes in your branch to fix and will re-run the tests: |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run ValidateMcCloud |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also tested validate in Mooncake with no issues
Overview/Summary
Cherry-picked API version updates from #245 which have not been yet updated since that one was created.
Related to #247
This PR fixes/adds/changes/removes
One example of this kind of case Azure/bicep#5581 (comment)
Also fixes location in pipelines being consistently taken from key vault/variable instead of hardcoded in places to
eastus
Breaking Changes
Testing Evidence
Should be as long as e2e tests pass.
As part of this Pull Request I have
main
branch