Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest API versions in all modules #293

Merged
merged 5 commits into from
Jul 26, 2022

Conversation

olljanat
Copy link
Contributor

@olljanat olljanat commented Jul 22, 2022

Overview/Summary

Cherry-picked API version updates from #245 which have not been yet updated since that one was created.

Related to #247

This PR fixes/adds/changes/removes

One example of this kind of case Azure/bicep#5581 (comment)

Also fixes location in pipelines being consistently taken from key vault/variable instead of hardcoded in places to eastus

Breaking Changes

  • Private DNS Zones vNet linking name made unique to ensure can be used multiple times for vNets with the same names:
    image

Testing Evidence

Should be as long as e2e tests pass.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated tests (if required) Unit - Linting - E2E (End-To-End)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
  • If relevant, created or updated Code Tours here

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Jul 22, 2022
@jtracey93
Copy link
Collaborator

/azp run validate az cloud

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 added enhancement and removed Needs: Triage 🔍 Needs triaging by the team labels Jul 22, 2022
@olljanat
Copy link
Contributor Author

oh, I totally forgot that those Azure Pipelines are not public.
@jtracey93 can you copy pipeline logs/errors from there to here as record?

@jtracey93
Copy link
Collaborator

oh, I totally forgot that those Azure Pipelines are not public. @jtracey93 can you copy pipeline logs/errors from there to here as record?

Hey @olljanat, yup just one of those things im afraid due to the way GitHub handles secrets in PRs from Forks.

The errors were mainly vwan DNS Zone related, so nothing you did but something your bigger change forced a run of the entire pipeline and highlighted. I have made some changes in your branch to fix and will re-run the tests:

image

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 requested a review from jfaurskov July 25, 2022 15:24
@jfaurskov
Copy link
Contributor

jfaurskov commented Jul 26, 2022

/azp run ValidateMcCloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tested validate in Mooncake with no issues

@jtracey93 jtracey93 merged commit 950d241 into Azure:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants