Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Invoke-PolicyToBicep.ps1 Scripts to Handle -'s, 's (spaces) & ' apostrophes + Fix #254 #288

Merged
merged 26 commits into from
Jul 19, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Jul 15, 2022

Overview/Summary

Update Invoke-PolicyToBicep.ps1 Scripts to Handle -'s, 's (spaces) & ' apostrophes + Fix #254

This PR fixes/adds/changes/removes

  1. Update Invoke-PolicyToBicep.ps1 Scripts to Handle -'s, 's (spaces) & ' apostrophes
  2. Fix 🪲 Bug Report - loadTextContent called multiple times for the same file causes bloat #254

Breaking Changes

None.

Testing Evidence

Local testing with ISD colleague has proved successful

image

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Jul 15, 2022
@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label Jul 15, 2022
@SeSeicht
Copy link
Contributor

additional Task woulb be: escape ' in names

@jtracey93
Copy link
Collaborator Author

additional Task woulb be: escape ' in names

Hey @SeSeicht could you provide some more explanation or screenshots of what you mean here as I can't work it out 👍

@SeSeicht
Copy link
Contributor

additional Task woulb be: escape ' in names

Hey @SeSeicht could you provide some more explanation or screenshots of what you mean here as I can't work it out 👍

This for example
image

@jtracey93 jtracey93 changed the title Update Invoke-PolicyToBicep.ps1 Scripts to Handle -'s and 's (spaces) Update Invoke-PolicyToBicep.ps1 Scripts to Handle -'s, 's (spaces) & ' apostrophes Jul 18, 2022
@jtracey93 jtracey93 changed the title Update Invoke-PolicyToBicep.ps1 Scripts to Handle -'s, 's (spaces) & ' apostrophes Update Invoke-PolicyToBicep.ps1 Scripts to Handle -'s, 's (spaces) & ' apostrophes + Fix #254 Jul 18, 2022
@jtracey93
Copy link
Collaborator Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the initial lines at the top of the scripts I have not comments

Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
@ghost ghost removed the Needs: Author Feedback label Jul 19, 2022
Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
@jtracey93 jtracey93 requested a review from jfaurskov July 19, 2022 07:55
Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 948e79d into Azure:main Jul 19, 2022
@jtracey93 jtracey93 deleted the fix-pol-to-bicep-hyphens branch July 19, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - loadTextContent called multiple times for the same file causes bloat
3 participants