Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure function to remove used subscriptions #287

Merged
merged 12 commits into from
Jul 13, 2022

Conversation

jfaurskov
Copy link
Contributor

@jfaurskov jfaurskov commented Jul 12, 2022

Overview/Summary

This PR includes code and pipeline to create an Azure function to cancel PR validation subscriptions once the PR has been closed. Described in this bug

This PR fixes/adds/changes/removes

  1. The .github/azFunction directory with associated files.

Breaking Changes

N/A

Testing Evidence

Succesful pipeline run can be seen here

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Jul 12, 2022
@jfaurskov jfaurskov requested a review from jtracey93 July 12, 2022 11:19
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, just a few nit picking bits 👍

.github/azFunction/AzFunctionCode/.gitignore Outdated Show resolved Hide resolved
.github/azFunction/AzFunctionCode/README.md Outdated Show resolved Hide resolved
.github/azFunction/AzFunctionCode/timerschedule/readme.md Outdated Show resolved Hide resolved
.github/azFunction/AzFunctionInfrastructure/main.bicep Outdated Show resolved Hide resolved
.github/azFunction/AzFunctionInfrastructure/main.bicep Outdated Show resolved Hide resolved
@ghost ghost removed the Needs: Author Feedback label Jul 12, 2022
@jfaurskov jfaurskov requested a review from jtracey93 July 12, 2022 14:36
@jfaurskov
Copy link
Contributor Author

/azp run ValidateazCloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice stuff.

Just the linter error to fix. I dont think you need the plaintext bit specified. Worth testing without i think

@jtracey93
Copy link
Collaborator

@jfaurskov can you also remove the old github action in this repo that does the cancelling as part of this PR 👍

@ghost ghost removed the Needs: Author Feedback label Jul 13, 2022
@jfaurskov
Copy link
Contributor Author

/azp run ValidateazCloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfaurskov
Copy link
Contributor Author

/azp run ValidateazCloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfaurskov jfaurskov requested a review from jtracey93 July 13, 2022 08:12
@jfaurskov jfaurskov merged commit 6424893 into Azure:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Needs triaging by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants