-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure function to remove used subscriptions #287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, just a few nit picking bits 👍
.github/azFunction/AzFunctionCode/cancelSubscriptions/readme.md
Outdated
Show resolved
Hide resolved
.github/azFunction/AzFunctionCode/cancelSubscriptions/sample.dat
Outdated
Show resolved
Hide resolved
/azp run ValidateazCloud |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice stuff.
Just the linter error to fix. I dont think you need the plaintext bit specified. Worth testing without i think
@jfaurskov can you also remove the old github action in this repo that does the cancelling as part of this PR 👍 |
/azp run ValidateazCloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run ValidateazCloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Overview/Summary
This PR includes code and pipeline to create an Azure function to cancel PR validation subscriptions once the PR has been closed. Described in this bug
This PR fixes/adds/changes/removes
Breaking Changes
N/A
Testing Evidence
Succesful pipeline run can be seen here
As part of this Pull Request I have
main
branch