Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALZ Resource Types Script and Update Workflow #273

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Add ALZ Resource Types Script and Update Workflow #273

merged 4 commits into from
Jun 29, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Jun 28, 2022

Overview/Summary

Add ALZ Resource Types Script and Update Workflow

This PR fixes/adds/changes/removes

  1. Add ALZ Resource Types Script and Update Workflow

Breaking Changes

None

Testing Evidence

Linting checks and workflow run itself will be sufficent
https://github.com/Azure/ALZ-Bicep/runs/7097377848?check_suite_focus=true#step:4:54

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Jun 28, 2022
@jtracey93 jtracey93 requested a review from jfaurskov June 28, 2022 16:56
@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label Jun 28, 2022
@jtracey93
Copy link
Collaborator Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering about what the script is for, as it doesn't look to be used anywhere?

@jtracey93
Copy link
Collaborator Author

Wondering about what the script is for, as it doesn't look to be used anywhere?

Just replied to the comment 👍

Not used but there for the future if we decide we want that capability in the future. Also handy to run locally instead of having to take it from the workflow etc.

@ghost ghost removed the Needs: Author Feedback label Jun 29, 2022
@jfaurskov jfaurskov self-requested a review June 29, 2022 08:16
@jtracey93 jtracey93 merged commit 2071e72 into Azure:main Jun 29, 2022
@jtracey93 jtracey93 deleted the resource-types-script branch June 29, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants