-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch policy library for Azure China #253
Conversation
…/ALZ-Bicep into patch-policy-library-china
…er/ALZ-Bicep into patch-policy-library-china
infra-as-code/bicep/modules/policy/assignments/alzDefaults/mc-alzDefaultPolicyAssignments.bicep
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/assignments/alzDefaults/mc-alzDefaultPolicyAssignments.bicep
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/assignments/alzDefaults/mc-alzDefaultPolicyAssignments.bicep
Show resolved
Hide resolved
infra-as-code/bicep/modules/policy/assignments/alzDefaults/mc-alzDefaultPolicyAssignments.bicep
Show resolved
Hide resolved
...icy/assignments/lib/china/policy_assignments/policy_assignment_es_enable_ddos_vnet.tmpl.json
Show resolved
Hide resolved
.../modules/policy/definitions/lib/china/policy_definitions/_mc_policyDefinitionsBicepInput.txt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @faister :-) Added a couple of suggestions. Also If you could merge with main and put the validation of the mc-alzdefaultpolicyassignments into the /tests/pipelines/mc-base-unit-validate.yml pipeline in place of the current alzdefaultpolicyassignments (line 81 - 87) that would be ace!
…policy-library-china
…alzDefaultPolicyAssignments.bicep Co-authored-by: Jan Faurskov <22591930+jfaurskov@users.noreply.github.com>
…er/ALZ-Bicep into patch-policy-library-china
Thanks @jfaurskov, done updated tests/pipelines/mc-base-unit-validate.yml and tested it in az cli successfully. see attached output. |
/azp run ValidateAzCloud |
/azp run ValidateMcCloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run ValidateAzCloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run ValidateAzCloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Overview/Summary
This PR ensures policy definitions/policy set definitions along with policy assignments all work in Azure China. Internal SE backlog item here. This is because there are some policy definition differences in China especially wrt to the MS Defender for Cloud policies, hence there was a separate policy assignment definition in the upstream enterprise-scale repo.
Just to be sure, re-tested the entire deployment flow as per https://github.com/Azure/ALZ-Bicep/wiki/DeploymentFlow and made some fixes.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Tested workflow manual run successfully in my forked repo
As part of this Pull Request I have
main
branch