Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add microsoft.com exclusion and increase timeout for Markdown Link Checker #235

Merged
merged 5 commits into from
May 13, 2022
Merged

Add microsoft.com exclusion and increase timeout for Markdown Link Checker #235

merged 5 commits into from
May 13, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented May 13, 2022 •
edited
Loading

Overview/Summary

Add microsoft.com exclusion and increase timeout for Markdown Link Checker

This PR fixes/adds/changes/removes

  1. Fixes 🪲 Bug Report - Markdown Link Checker Failing on some microsoft.com URIs #234

Breaking Changes

None

Testing Evidence

The action will run on this PR will be the test and evidence

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated tests (if required) Unit - Linting - E2E (End-To-End)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
  • If relevant, created or updated Code Tours here

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 13, 2022
@jtracey93 jtracey93 requested a review from jfaurskov May 13, 2022 09:28
@jtracey93 jtracey93 added bug and removed Needs: Triage 🔍 Needs triaging by the team labels May 13, 2022
@jtracey93 jtracey93 requested review from ejhenry and removed request for jfaurskov May 13, 2022 09:39
ejhenry
ejhenry approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93
Copy link
Collaborator Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 17418c6 into Azure:main May 13, 2022
@jtracey93 jtracey93 deleted the fix-234 branch May 13, 2022 15:47
MiYanni added a commit to dotnet/project-system that referenced this pull request Jul 18, 2022
@MiYanni
Ignore microsoft urls. See: Azure/ALZ-Bicep#234 and PR: Azure/ALZ-Bic…
f387129 
…ep#235
@MiYanni MiYanni mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhenry ejhenry ejhenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - Markdown Link Checker Failing on some microsoft.com URIs
2 participants
@jtracey93 @ejhenry