Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPN Guidance and Elevation - Feedback Issue 145 #230

Merged
merged 4 commits into from
May 5, 2022
Merged

SPN Guidance and Elevation - Feedback Issue 145 #230

merged 4 commits into from
May 5, 2022

Conversation

4pplied
Copy link
Contributor

@4pplied 4pplied commented May 5, 2022

Overview/Summary

Further guidance on SPN creation and elevation to management root management group in preparation for automation. relates

This PR fixes/adds/changes/removes

  1. Updates the DeploymentFlow.MD in the Wiki with relevant information
  2. Further guidance in accordance to 👂 Feedback - Adding a Service Principal to deploy ALZ-Bicep. -- Pre-Requisites to Wiki #145

Breaking Changes

  1. Updated guidance on how to use SPNs for automation and management group RBAC

Testing Evidence

image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated tests (if required) Unit - Linting - E2E (End-To-End)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
  • If relevant, created or updated Code Tours here

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 5, 2022
docs/wiki/DeploymentFlow.md Outdated Show resolved Hide resolved
@jtracey93 jtracey93 self-assigned this May 5, 2022
@jtracey93 jtracey93 added documentation and removed Needs: Triage 🔍 Needs triaging by the team labels May 5, 2022
@ghost ghost removed the Needs: Author Feedback label May 5, 2022
@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit b3409ec into Azure:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👂 Feedback - Adding a Service Principal to deploy ALZ-Bicep. -- Pre-Requisites to Wiki
2 participants