-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected some typo's, camelCasing inconsistency fixes and added defaults #229
Conversation
@jtracey93 For some reason I can't set a comment, but in the README in the spokeNetworking folder, it says that the spokeNetworking.bicep creates a subnet. This is not what the template does. Is this an error or shall I add the possibility to add one or more subnets? |
Hey @johnlokerse, this is indeed and error. We do not create subnets today as this would mean a complex object input parameter today which we cannot validate. So please remove from the docs 👍 |
@jtracey93 Done! |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
This PR fixes/adds/changes/removes
Breaking Changes
parDnsServerIPs
when using a parameter file with the "old" parameter name.JT Notes
parDNSServerIPArray
toparDnsServerIPs
parSpoketoHubRouteTableName
toparSpokeToHubRouteTableName
As part of this Pull Request I have
main
branch