Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected some typo's, camelCasing inconsistency fixes and added defaults #229

Merged
merged 4 commits into from
May 5, 2022

Conversation

johnlokerse
Copy link
Contributor

@johnlokerse johnlokerse commented May 5, 2022

This PR fixes/adds/changes/removes

  1. Corrected typo's
  2. Fixes to some camelCasing inconsistencies
  3. Added defaults to the description

Breaking Changes

  1. If someone copy and paste this template it will break on parDnsServerIPs when using a parameter file with the "old" parameter name.

JT Notes

  • parDNSServerIPArray to parDnsServerIPs
  • parSpoketoHubRouteTableName to parSpokeToHubRouteTableName

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated tests (if required) Unit - Linting - E2E (End-To-End)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
  • If relevant, created or updated Code Tours here

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 5, 2022
@johnlokerse
Copy link
Contributor Author

@jtracey93 For some reason I can't set a comment, but in the README in the spokeNetworking folder, it says that the spokeNetworking.bicep creates a subnet. This is not what the template does. Is this an error or shall I add the possibility to add one or more subnets?

@jtracey93
Copy link
Collaborator

@jtracey93 For some reason I can't set a comment, but in the README in the spokeNetworking folder, it says that the spokeNetworking.bicep creates a subnet. This is not what the template does. Is this an error or shall I add the possibility to add one or more subnets?

Hey @johnlokerse, this is indeed and error. We do not create subnets today as this would mean a complex object input parameter today which we cannot validate.

So please remove from the docs 👍

@johnlokerse
Copy link
Contributor Author

@jtracey93 Done!

@jtracey93
Copy link
Collaborator

/azp run e2e

@jtracey93 jtracey93 self-requested a review May 5, 2022 13:15
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 added documentation and removed Needs: Triage 🔍 Needs triaging by the team labels May 5, 2022
@jtracey93 jtracey93 self-assigned this May 5, 2022
@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@jtracey93 jtracey93 merged commit d9411ec into Azure:main May 5, 2022
@johnlokerse johnlokerse deleted the defaults-textual-fixes branch May 5, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants