Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Various Features & Fix Various Bugs to VWAN & Hub Networking #226

Merged
merged 12 commits into from
May 5, 2022
Merged

Add Various Features & Fix Various Bugs to VWAN & Hub Networking #226

merged 12 commits into from
May 5, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented May 3, 2022

Overview/Summary

Add Various Features & Fix Various Bugs to VWAN & Hub Networking

This PR fixes/adds/changes/removes

  1. Fixes 💡 Feature Request - Add AZ Support for Azure Firewall in Secure vHub Model - vwanConnectivity.bicep #205 for both VWAN & Hub/Spoke model
  2. Fixes Azure Firewall with Virtual Hub deployment fails as unable to set Public IP #219
  3. Fixes 💡 Feature Request - VWAN Route Table Missing In VWAN If Deploy Azure Firewall in Secure Hub Model #225
  4. Add Firewall Policy to Hub/Spoke model
  5. Added AZ support to publicIp module
  6. Updated bicepconfig.json for vwanConnectivity.bicep as added DNS zones
  7. Add Private DNS Zones to vwanConnectivity.bicep
  8. Add DDoS Std Plan to vwanConnectivity.bicep

Breaking Changes

  1. Renamed parHubVirtualNetworkId to parVirtualNetworkIdToLink in privateDnsZones.bicep module

Testing Evidence

image
image
image
image
image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated tests (if required) Unit - Linting - E2E (End-To-End)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
  • If relevant, created or updated Code Tours here

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 3, 2022
@jtracey93 jtracey93 requested a review from jfaurskov May 3, 2022 17:28
@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label May 3, 2022
@jtracey93 jtracey93 marked this pull request as ready for review May 3, 2022 17:28
@jtracey93
Copy link
Collaborator Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

4pplied
4pplied previously approved these changes May 5, 2022
Copy link
Contributor

@4pplied 4pplied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93
Copy link
Collaborator Author

E2E checks being ignored as manually tested and evidenced in PR by @jtracey93

Markdown link checks being ignored due to false positives

@jtracey93 jtracey93 merged commit d5f712d into Azure:main May 5, 2022
@jtracey93 jtracey93 deleted the fix-219-vwan branch May 5, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants