-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Various Features & Fix Various Bugs to VWAN & Hub Networking #226
Conversation
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
infra-as-code/bicep/modules/vwanConnectivity/mc-vwanConnectivity.parameters.example.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
infra-as-code/bicep/modules/vwanConnectivity/mc-vwanConnectivity.parameters.example.json
Show resolved
Hide resolved
E2E checks being ignored as manually tested and evidenced in PR by @jtracey93 Markdown link checks being ignored due to false positives |
Overview/Summary
Add Various Features & Fix Various Bugs to VWAN & Hub Networking
This PR fixes/adds/changes/removes
vwanConnectivity.bicep
#205 for both VWAN & Hub/Spoke modelpublicIp
modulebicepconfig.json
forvwanConnectivity.bicep
as added DNS zonesvwanConnectivity.bicep
vwanConnectivity.bicep
Breaking Changes
parHubVirtualNetworkId
toparVirtualNetworkIdToLink
inprivateDnsZones.bicep
moduleTesting Evidence
As part of this Pull Request I have
main
branch