Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vnetPeering documentation and samples #220

Merged
merged 6 commits into from
Apr 29, 2022
Merged

Update vnetPeering documentation and samples #220

merged 6 commits into from
Apr 29, 2022

Conversation

jfaurskov
Copy link
Contributor

@jfaurskov jfaurskov commented Apr 27, 2022 •
edited
Loading

Overview/Summary

Adds deployment instructions to vnetPeering module, and updates E2E testing pipeline to use parameter files as well.

This PR fixes/adds/changes/removes

  1. Adds specific commands to deploy vnet peering to readme for module.
  2. Adds output section readme for module.
  3. Adds vnetPeering.parameters.example.json
  4. Updates E2E testing pipeline to use parameters file as well for vnet peerings.

Breaking Changes

N/A

Testing Evidence

Primarily documentation, vnet peering deployed successfully as part of pipeline.
image

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated tests (if required) Unit - Linting - E2E (End-To-End)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
  • If relevant, created or updated Code Tours here

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 27, 2022
@jfaurskov
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfaurskov jfaurskov changed the title Push updates Update vnetPeering documentation and samples Apr 27, 2022
@jfaurskov
Copy link
Contributor Author

/azp run e2e

@jfaurskov jfaurskov requested a review from jtracey93 April 27, 2022 15:11
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jtracey93
jtracey93 requested changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few bits 👍

infra-as-code/bicep/modules/vnetPeering/README.md Outdated Show resolved Hide resolved
infra-as-code/bicep/modules/vnetPeering/vnetPeering.parameters.example.json Outdated Show resolved Hide resolved
@jfaurskov @jtracey93
Update infra-as-code/bicep/modules/vnetPeering/README.md
6b911bc 
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
@ghost ghost removed the Needs: Author Feedback label Apr 29, 2022
@jfaurskov @jtracey93
Update infra-as-code/bicep/modules/vnetPeering/vnetPeering.parameters…
b13c95e 
….example.json

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
@jfaurskov
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jtracey93
jtracey93 approved these changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if E2E test complete successfully @jfaurskov 👍

@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label Apr 29, 2022
@jfaurskov jfaurskov merged commit 5601eec into Azure:main Apr 29, 2022
@jfaurskov jfaurskov mentioned this pull request May 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfaurskov @jtracey93