Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ACR publish script #197

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

jfaurskov
Copy link
Contributor

Overview/Summary

This pull request changes scripts used for ACR publish so that all modules are included, not just the upper levels. Described in #186

This PR fixes/adds/changes/removes

  1. Change docs/scripts/createRGandcallBicep.ps1 to do a recursive search for *.bicep files and exclude the orch-hubSpoke.bicep file.
  2. Change docs/scripts/createRGandcallBicep.sh to do a recursive search for .bicep files and exclude files in ./infra-as-code/bicep/modules/unstable.

Breaking Changes

N/A

Testing Evidence

Modules in ACR with existing Bash script.
azcliold

Modules after running Bash script in this PR.
azclinee1
azclinee2

Modules in ACR with existing PowerShell script.
psold

Modules after running PowerShell script in this PR.
psnew1
psnew2

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • [] Updated relevant and associated documentation.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Mar 29, 2022
@jfaurskov jfaurskov requested a review from jtracey93 March 29, 2022 13:07
@jtracey93 jtracey93 added bug and removed Needs: Triage 🔍 Needs triaging by the team labels Mar 29, 2022
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍👍

@jfaurskov jfaurskov merged commit 4748322 into Azure:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - Example ACR publish scripts don't publish policy modules
2 participants