Fixed parDdosEnabled/parDdosPlanName camel casing

[cbezenco]

Overview/Summary

Fix for bug #195

This PR fixes/adds/changes/removes

Changed casing for parDDoS to parDdos on parDdosEnabled and parDdosPlanName in hubnetworking.bicep

Breaking Changes

None

Testing Evidence

PS C:\GithubCamelCasingFix\ALZ-Bicep> New-AzResourceGroupDeployment `

-TemplateFile infra-as-code/bicep/modules/hubNetworking/hubNetworking.bicep -TemplateParameterFile infra-as-code/bicep/modules/hubNetworking/hubNetworking.parameters.example.json
-parLocation $varDeplRegion -parBastionEnabled $varBastionEnabled
-parDdosEnabled $varDdosEnabled -parAzureFirewallEnabled $varAzureFirewallEnabled
-parPrivateDNSZonesEnabled $varPrivateDNSZonesEnabled -parCompanyPrefix $varTopLevelMGPrefix
-parDdosPlanName $varDdosPlanName -parBastionName $varBastionName
-parBastionSku $varBastionSku -parPublicIPSku $varPublicIPSku
-parTags $varTags -parHubNetworkAddressPrefix $varHubNetworkAddressPrefix
-parHubNetworkName $varHubNetworkName -parAzureFirewallName $varAzureFirewallName
-parAzureFirewallTier $varAzureFirewallTier -parHubRouteTableName $varHubRouteTableName
-parDNSServerIPArray $varDNSServerIPArray -parNetworkDNSEnableProxy $varNetworkDNSEnableProxy
-parDisableBGPRoutePropagation $varDisableBGPRoutePropagation `
-ResourceGroupName $varConnectionRG

DeploymentName : hubNetworking
ResourceGroupName : rg-LAB2-hub
ProvisioningState : Succeeded
Timestamp : 3/29/2022 8:05:01 AM
Mode : Incremental
TemplateLink :
Parameters :

As part of this Pull Request I have

• Checked for duplicate Pull Requests
• Associated it with relevant ADO items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated relevant and associated documentation. Checked doc no change required.

[cbezenco]

I cannot access ADO item link so I have not checked the item when creating the pull request.
Associated it with relevant ADO items

[jtracey93]

Thanks @cbezenco,

Can you also change the output and the resources symbolic name to all follow camelCasing properly as well?

Also please update the docs if required.

Massively appreciate this and look forward to merging once ready 👍

[jtracey93]

I cannot access ADO item link so I have not checked the item when creating the pull request.

Associated it with relevant ADO items

That's fine. I need to update the PR template

[cbezenco]

Ok will do.

[jtracey93]

Thanks @cbezenco, just a few more small bits 👍👍

[jtracey93]

/azp run e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jtracey93]

Thanks @cbezenco,

can we ensue that the resource name parameter input for the DDoS plan is alz-ddos-plan across all references including parameter example files?

Thanks

[cbezenco]

DDoS plan is alz-ddos-plan across all references. Done and tested successfully.

[jtracey93]

Can still see references to alz-ddos-Plan instead of alz-ddos-plan https://github.com/cbezenco/ALZ-Bicep/blob/71b660ade82e76ea8cb5c7b8dbea707e551c7a84/infra-as-code/bicep/modules/hubNetworking/hubNetworking.parameters.example.json#L52

[zebak007]

Can still see references to alz-ddos-Plan instead of alz-ddos-plan https://github.com/cbezenco/ALZ-Bicep/blob/71b660ade82e76ea8cb5c7b8dbea707e551c7a84/infra-as-code/bicep/modules/hubNetworking/hubNetworking.parameters.example.json#L52

Weird... I can see it but doing a github searching on my repo does not report it (see snapshoot). I used Github search for the other changes and it was working. Am I doing something wrong ?

I did file search using Visual Studio Code and it did report 3 more isntances that I fixed. I hope this is ok now... Still wonder why Github search does not seem to work on that particular search.

[jtracey93]

/azp run e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jtracey93]

LGTM 🚢