Add type to custom role definitions

[olljanat]

Overview/Summary

Correct custom roles status detection for Get-AzManagementGroupDeploymentWhatIfResult

This PR fixes/adds/changes/removes

1. Add type to custom role definitions

Breaking Changes

N/A

Testing Evidence

Before this PR:

Get-AzManagementGroupDeploymentWhatIfResult ...

Resource and property changes are indicated with these symbols:
  - Delete
  ~ Modify

The deployment will update the following scope:

Scope: /providers/Microsoft.Management/ManagementGroups/mg-sdw-root

  ~ Microsoft.Authorization/roleDefinitions/4308c4e6-07d5-534f-9e18-32769872a3f4 [2018-01-01-preview]
    - properties.type: "CustomRole"

  ~ Microsoft.Authorization/roleDefinitions/4a200286-e2a0-5239-aa8f-fe0a90dd2eb5 [2018-01-01-preview]
    - properties.type: "CustomRole"

  ~ Microsoft.Authorization/roleDefinitions/8736d87d-8d31-53be-b952-a04c8d470f69 [2018-01-01-preview]
    - properties.type: "CustomRole"

  ~ Microsoft.Authorization/roleDefinitions/b2960c40-d3db-5190-94c1-5b07c9547956 [2018-01-01-preview]
    - properties.type: "CustomRole"

Resource changes: 4 to modify.

After this PR:

Get-AzManagementGroupDeploymentWhatIfResult ...

Resource and property changes are indicated with this symbol:
  = NoChange

The deployment will update the following scope:

Scope: /providers/Microsoft.Management/ManagementGroups/mg-sdw-root

  = Microsoft.Authorization/roleDefinitions/4308c4e6-07d5-534f-9e18-32769872a3f4 [2018-01-01-preview]
  = Microsoft.Authorization/roleDefinitions/4a200286-e2a0-5239-aa8f-fe0a90dd2eb5 [2018-01-01-preview]
  = Microsoft.Authorization/roleDefinitions/8736d87d-8d31-53be-b952-a04c8d470f69 [2018-01-01-preview]
  = Microsoft.Authorization/roleDefinitions/b2960c40-d3db-5190-94c1-5b07c9547956 [2018-01-01-preview]

Resource changes: 4 no change.

As part of this Pull Request I have

• Checked for duplicate Pull Requests
• Associated it with relevant ADO items
• Ensured my code/branch is up-to-date with the latest changes in the main branch
• Performed testing and provided evidence.
• Updated relevant and associated documentation.

[jtracey93]

/azp run e2e

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jtracey93]

Thanks @olljanat, good spot and catch!

Have tested myself and all good