Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useRemoteGatewaysAdded property added to virtualNetworkPeer module #188

Merged
merged 1 commit into from
Mar 14, 2022
Merged

useRemoteGatewaysAdded property added to virtualNetworkPeer module #188

merged 1 commit into from
Mar 14, 2022

Conversation

KiZach
Copy link
Contributor

@KiZach KiZach commented Mar 13, 2022

Overview/Summary

The virtualNetworkPeer module does not support the useRemoteGatewaysAdded property. This has been fixed.

This PR fixes/adds/changes/removes

  1. Adds useRemoteGatewaysAdded to the 'Microsoft.Network/virtualNetworks/virtualNetworkPeerings' resource in the module.

Breaking Changes

N/A

Testing Evidence

Property has been added and tested with a standard Hub and Spoke setup.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Mar 13, 2022
@KiZach KiZach mentioned this pull request Mar 13, 2022
Closed
@jtracey93 jtracey93 added Area: Networking and removed Needs: Triage 🔍 Needs triaging by the team labels Mar 14, 2022
@jtracey93 jtracey93 self-assigned this Mar 14, 2022
@jtracey93
Copy link
Collaborator

/azp run e2e

@jtracey93 jtracey93 linked an issue Mar 14, 2022 that may be closed by this pull request
🪲 Bug Report - virtualNetworkPeer module missing use remote gateway setting. #189
Closed
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jtracey93
jtracey93 approved these changes Mar 14, 2022
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 5498666 into Azure:main Mar 14, 2022
@KiZach KiZach deleted the virtualnetworkpeer-module-useremotegateways-fix branch March 14, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees

@jtracey93 jtracey93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - virtualNetworkPeer module missing use remote gateway setting.
2 participants
@KiZach @jtracey93