Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spoke vnet tagging #184

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Add spoke vnet tagging #184

merged 2 commits into from
Mar 11, 2022

Conversation

ejhenry
Copy link
Contributor

@ejhenry ejhenry commented Mar 11, 2022

Overview/Summary

Add tagging parameter to spoke vnet resource

This PR fixes/adds/changes/removes

  1. Add tagging parameter to spoke vnet resource
  2. Add tagging parameter to sample parameters file

Breaking Changes

None

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ejhenry ejhenry requested a review from jtracey93 March 11, 2022 16:58
@ejhenry ejhenry self-assigned this Mar 11, 2022
@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jtracey93
jtracey93 approved these changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@ejhenry ejhenry merged commit c23445b into Azure:main Mar 11, 2022
@ejhenry ejhenry deleted the ado-100634 branch March 11, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees

@ejhenry ejhenry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejhenry @jtracey93