Swap individual policy assignments to alzDefaultPolicyAssignments module in E2E tests
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jtracey93
requested changes
Mar 11, 2022
There was a problem hiding this comment.
A few bits, also really want to ensure we have enough delay or retry logic if the policy assignments fail due to Azure/Enterprise-Scale#902.
Can we add some error handling if the deployment fails due to this, to wait for say 5 mins and try again, as this should give replication a chance to catch up in ARM
jtracey93
changed the title
alzDefaultPolicyAssignments module in E2E tests
jtracey93
added
enhancement
and removed
Needs: Triage 🔍
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
|
Looking into the error handling bits |
jtracey93
requested changes
Mar 22, 2022
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…rskov/ALZ-Bicep into alzdefaultpolassignunittest
|
/azp run E2E |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run E2E |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run E2E |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run E2E |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run E2E |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jtracey93
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Update unit test pipeline to include alzDefaultPolicyAssignments
This PR fixes/adds/changes/removes
Breaking Changes
N/A
Testing Evidence
Ran script manually, with custom policies not deployed to root of ALZ management group structure.
After failing script waits 30 seconds and then retries.
Separately entered the policies while script was running and it succeded.
As part of this Pull Request I have
mainbranch