Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add condition to Enable-DDoS-VNET policy assignments in alzDefaultPolicyAssignments #182

Merged
merged 4 commits into from
Mar 11, 2022
Merged

Add condition to Enable-DDoS-VNET policy assignments in alzDefaultPolicyAssignments #182

merged 4 commits into from
Mar 11, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Mar 10, 2022 •
edited
Loading

Overview/Summary

Add condition to Enable-DDoS-VNET policy assignments in alzDefaultPolicyAssignments. If parDdosProtectionPlanId is an empty string, then the module will not assign the Enable-DDoS-VNET to connectivity and landing zones Management Groups to prevent VNET deployment failures if a DDoS plan is not provided.

This PR fixes/adds/changes/removes

  1. Fixes Not having a DDoS Protection Standard plan is causing deployment issues #181

Breaking Changes

None

Testing Evidence

Disabled

image

image

image

image

Enabled

image

image

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Mar 10, 2022
@jtracey93 jtracey93 requested a review from jfaurskov March 10, 2022 19:55
@jtracey93 jtracey93 added bug and removed Needs: Triage 🔍 Needs triaging by the team labels Mar 11, 2022
jfaurskov
jfaurskov approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 0f5d753 into Azure:main Mar 11, 2022
@jtracey93 jtracey93 deleted the fix-181 branch March 11, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfaurskov jfaurskov jfaurskov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not having a DDoS Protection Standard plan is causing deployment issues
2 participants
@jtracey93 @jfaurskov