Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Databricks Default Policy Assignments to Corp MG to Match ALZ Accelerator Experience #177

Merged
merged 6 commits into from
Mar 9, 2022
Merged

Add Missing Databricks Default Policy Assignments to Corp MG to Match ALZ Accelerator Experience #177

merged 6 commits into from
Mar 9, 2022

Conversation

jtracey93
Copy link
Collaborator

@jtracey93 jtracey93 commented Mar 9, 2022

Overview/Summary

Add Missing Databricks Default Policy Assignments to Corp MG to match ALZ Accelerator experience

This PR fixes/adds/changes/removes

  1. Add 3 policy assignments for databricks to corp Management Groupto match ALZ Accelerator experience
    • Deny-DataB-Pip
    • Deny-DataB-Sku
    • Deny-DataB-Vnet
  2. Fixes ADO 100864

Breaking Changes

None

Testing Evidence

image
image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jtracey93 jtracey93 requested a review from jfaurskov March 9, 2022 12:22
@ghost
Copy link

ghost commented Mar 9, 2022

Hey jtracey93, thanks for creating this PR.

We noticed that this PR is ammending some things related to policies (definitions or assignments) 🔍

Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules.

So it may be that this PR may be closed and we ask you to re-submit the changes to the respective code in our other repo.

However, we will review and advise further anyway but this is just a friendly premptive message and reminder of how policies are used and updated in this repo.

Thanks from your friendly msft-bot.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Mar 9, 2022
@jtracey93
Copy link
Collaborator Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jfaurskov
jfaurskov previously approved these changes Mar 9, 2022
Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit f49c522 into Azure:main Mar 9, 2022
@jtracey93 jtracey93 deleted the add-data-pol-assignments branch March 10, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Needs triaging by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants