Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parameter order for hubnetworking #175

Merged
merged 5 commits into from
Mar 10, 2022
Merged

Update parameter order for hubnetworking #175

merged 5 commits into from
Mar 10, 2022

Conversation

jfaurskov
Copy link
Contributor

@jfaurskov jfaurskov commented Mar 7, 2022 •
edited
Loading

Overview/Summary

Proper ordering of parameters in hubnetworking module.

This PR fixes/adds/changes/removes

  1. Modifies order of parameters in hubnetworking.bicep so that related settings are in the same blocks
  2. Modifies order of parameters in hubNetworking.parameters.example.json file so it corresponds with parameter order in hubnetworking.bicep
  3. Modifies order of parameters in mc-hubNetworking.parameters.example.json file so it corresponds with parameter order in hubnetworking.bicep.
  4. Set ER Vnet gw sku to Standard in mc-hubNetworking.parameters.example.json as SKUs are different in mc
  5. Update readme to include line shift for PowerShell sample command line for mc.

Breaking Changes

N/A

Testing Evidence

Ran E2E for public cloud successfully.
Evidence for Mooncake:

image

image

image

image

image

image

image

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Mar 7, 2022
@jfaurskov
Copy link
Contributor Author

/azp run E2E

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfaurskov jfaurskov changed the title Add updated files Update parameter order for hubnetworking Mar 7, 2022
@jfaurskov jfaurskov requested review from jtracey93 and faister March 10, 2022 12:25
@jtracey93 jtracey93 added Area: Networking and removed Needs: Triage 🔍 Needs triaging by the team labels Mar 10, 2022
@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jtracey93
jtracey93 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 (once e2e completes)

@jfaurskov jfaurskov merged commit eabee47 into Azure:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

@faister faister Awaiting requested review from faister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfaurskov @jtracey93