-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize on parLocation for specifying Azure regions. #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rjygraham nice work. I think we need to also update the logging and resource group module as they don't use the new standard of parLocation here. They use some thing like parResourceGroupLocation etc. let's make them all the same 👍
Also in the contributing wiki page can we add a new "Standardised Common Parameter" section for things like this and tags etc.
@jtracey93 - due to disparity in China region availability for Log Analytics and Automation Accounts, I believe we'll need to leave the logging module with separate parameters for now: |
Lets chat on our sync tomorrow to understand more here. |
@rjygraham is this good to review again? With the changes we spoke about yesterday? |
@jtracey93 yes - all good to review. I just did another merge of main to resolve another conflict that was introduced. |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @rjygraham LGTM 🚢
Renames all instances of
parRegion
toparLocation
in code and documentation to be in alignment with the vast majority of ALZ-Bicep modules and ARM/TF ESLZ.This PR fixes/adds/changes/removes
parRegion
renamed toparLocation
Breaking Changes
parRegion
toparLocation
for deployments ofhubNetworking
andspokeNetworking
module parameter files.Testing Evidence
hubNetworking
spokeNetworking
As part of this Pull Request I have
main
branch