Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on parLocation for specifying Azure regions. #174

Merged
merged 9 commits into from
Mar 21, 2022

Conversation

rjygraham
Copy link
Contributor

@rjygraham rjygraham commented Mar 4, 2022

Renames all instances of parRegion to parLocation in code and documentation to be in alignment with the vast majority of ALZ-Bicep modules and ARM/TF ESLZ.

This PR fixes/adds/changes/removes

  1. All occurrences of parRegion renamed to parLocation

Breaking Changes

  1. Existing clones of the ALZ-Bicep repository will need to update parRegion to parLocation for deployments of hubNetworking and spokeNetworking module parameter files.

Testing Evidence

hubNetworking
image

spokeNetworking
image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Mar 4, 2022
@jtracey93 jtracey93 self-requested a review March 5, 2022 10:36
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjygraham nice work. I think we need to also update the logging and resource group module as they don't use the new standard of parLocation here. They use some thing like parResourceGroupLocation etc. let's make them all the same 👍

Also in the contributing wiki page can we add a new "Standardised Common Parameter" section for things like this and tags etc.

@jtracey93
Copy link
Collaborator

@rjygraham
Copy link
Contributor Author

@jtracey93 - due to disparity in China region availability for Log Analytics and Automation Accounts, I believe we'll need to leave the logging module with separate parameters for now: parAutomationAccountRegion and parLogAnalyticsWorkspaceLocation instead of a single parLocation parameter.

@jtracey93
Copy link
Collaborator

@jtracey93 Jack Tracey FTE - due to disparity in China region availability for Log Analytics and Automation Accounts, I believe we'll need to leave the logging module with separate parameters for now: parAutomationAccountRegion and parLogAnalyticsWorkspaceLocation instead of a single parLocation parameter.

Lets chat on our sync tomorrow to understand more here.

@jtracey93
Copy link
Collaborator

@rjygraham is this good to review again?

With the changes we spoke about yesterday?

@rjygraham
Copy link
Contributor Author

@jtracey93 yes - all good to review. I just did another merge of main to resolve another conflict that was introduced.

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rjygraham rjygraham requested a review from jtracey93 March 18, 2022 15:40
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @rjygraham LGTM 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants