Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining conditions for vWan deployment #172

Merged
merged 6 commits into from
Mar 4, 2022
Merged

Fix remaining conditions for vWan deployment #172

merged 6 commits into from
Mar 4, 2022

Conversation

jfaurskov
Copy link
Contributor

Overview/Summary

Fix remaining conditions for vWan deployment so that resource group, management group gets created and subscription moved.

This PR fixes/adds/changes/removes

  1. Add check for gitVwanOUTPUT to all steps where gitHubOUTPUT is verified, except for the actual hubnetworking deployment of course.

Breaking Changes

N/A

Testing Evidence

Last test run missed the things I have now added conditions for.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Mar 3, 2022
@jtracey93 jtracey93 self-requested a review March 4, 2022 15:31
@jtracey93 jtracey93 added hygiene and removed Needs: Triage 🔍 Needs triaging by the team labels Mar 4, 2022
jtracey93
jtracey93 approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfaurskov jfaurskov merged commit 62b0023 into Azure:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees

@jtracey93 jtracey93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfaurskov @jtracey93