Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging update #171

Merged
merged 5 commits into from
Mar 3, 2022
Merged

Tagging update #171

merged 5 commits into from
Mar 3, 2022

Conversation

KiZach
Copy link
Contributor

@KiZach KiZach commented Mar 3, 2022

Overview/Summary

Tagging support on resource group creation and logging resources

This PR fixes/adds/changes/removes

  1. Add possibility to add tags to resource group module
  2. Add possibility to add tags to logging resources created by the logging module

Breaking Changes

None

Testing Evidence

Tested in 2 different environments with Azure Devops pipeline configured as below:

  • task: AzureCLI@2
    displayName: Az CLI Deploy Logging Resource Group
    name: create_logging_rg
    inputs:
    azureSubscription: $(ServiceConnectionName)
    scriptType: 'bash'
    scriptLocation: 'inlineScript'
    inlineScript: |
    az account set --subscription $(LoggingSubId)
    echo $(Tags)
    az deployment sub create
    --template-file infra-as-code/bicep/modules/resourceGroup/resourceGroup.bicep
    --parameters parResourceGroupName=$(LoggingResourceGroupName) parResourceGroupLocation=$(Location) parTags="$(Tags)"
    --location $(Location)
    --name create_logging_rg-$(RunNumber)

  • task: AzureCLI@2
    displayName: Az CLI Deploy Logging
    name: create_logging
    inputs:
    azureSubscription: $(ServiceConnectionName)
    scriptType: 'bash'
    scriptLocation: 'inlineScript'
    inlineScript: |
    az account set --subscription $(LoggingSubId)
    az deployment group create
    --resource-group $(LoggingResourceGroupName)
    --template-file infra-as-code/bicep/modules/logging/logging.bicep
    --parameters parLogAnalyticsWorkspaceName=$(LogAnalyticsWorkspaceName) parLogAnalyticsWorkspaceLogRetentionInDays=$(LogAnalyticsRetentionInDays) parAutomationAccountName=$(AutomationAccountName) parTags="$(Tags)"
    --name create_logging-$(RunNumber)

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Mar 3, 2022
@ghost
Copy link

ghost commented Mar 3, 2022

CLA assistant check
All CLA requirements met.

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @KiZach, thanks for the PR. Just one small thing to fix.

infra-as-code/bicep/modules/logging/README.md Outdated Show resolved Hide resolved
@ghost ghost removed the Needs: Author Feedback label Mar 3, 2022
@jtracey93
Copy link
Collaborator

Looking good, kicking off tests before merging

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

Only cleanup task failed which we will pickup offline in another issue. However, the deployment and other tests succeeded

image

@jtracey93 jtracey93 merged commit 3ad115f into Azure:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants