-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagging update #171
Merged
Merged
Tagging update #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtracey93
requested changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KiZach, thanks for the PR. Just one small thing to fix.
ghost
removed
the
Needs: Author Feedback
label
Mar 3, 2022
jtracey93
approved these changes
Mar 3, 2022
Looking good, kicking off tests before merging |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Tagging support on resource group creation and logging resources
This PR fixes/adds/changes/removes
Breaking Changes
None
Testing Evidence
Tested in 2 different environments with Azure Devops pipeline configured as below:
task: AzureCLI@2
displayName: Az CLI Deploy Logging Resource Group
name: create_logging_rg
inputs:
azureSubscription: $(ServiceConnectionName)
scriptType: 'bash'
scriptLocation: 'inlineScript'
inlineScript: |
az account set --subscription $(LoggingSubId)
echo $(Tags)
az deployment sub create
--template-file infra-as-code/bicep/modules/resourceGroup/resourceGroup.bicep
--parameters parResourceGroupName=$(LoggingResourceGroupName) parResourceGroupLocation=$(Location) parTags="$(Tags)"
--location $(Location)
--name create_logging_rg-$(RunNumber)
task: AzureCLI@2
displayName: Az CLI Deploy Logging
name: create_logging
inputs:
azureSubscription: $(ServiceConnectionName)
scriptType: 'bash'
scriptLocation: 'inlineScript'
inlineScript: |
az account set --subscription $(LoggingSubId)
az deployment group create
--resource-group $(LoggingResourceGroupName)
--template-file infra-as-code/bicep/modules/logging/logging.bicep
--parameters parLogAnalyticsWorkspaceName=$(LogAnalyticsWorkspaceName) parLogAnalyticsWorkspaceLogRetentionInDays=$(LogAnalyticsRetentionInDays) parAutomationAccountName=$(AutomationAccountName) parTags="$(Tags)"
--name create_logging-$(RunNumber)
As part of this Pull Request I have
main
branch