Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about #disable-next-line to each usage and FAQ #167

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Add note about #disable-next-line to each usage and FAQ #167

merged 3 commits into from
Feb 28, 2022

Conversation

jtracey93
Copy link
Collaborator

Overview/Summary

Add note about #disable-next-line to each usage and FAQ

This PR fixes/adds/changes/removes

  1. Fixes ❓👂 Question/Feedback - Explain when linter warnings should be disabled #153

Breaking Changes

None

Testing Evidence

Linting & Bicep Build will suffice which will run as part of this PR submission

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jtracey93 jtracey93 requested a review from jfaurskov February 28, 2022 11:15
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Feb 28, 2022
jfaurskov
jfaurskov suggested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely clear what the testDnsZones.bicep file is for?

@ghost ghost removed the Needs: Author Feedback label Feb 28, 2022
@jtracey93
Copy link
Collaborator Author

Not entirely clear what the testDnsZones.bicep file is for?

Good catch thought I removed it but clearly hadn't. Have now 👍

@jtracey93 jtracey93 requested a review from jfaurskov February 28, 2022 11:28
@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label Feb 28, 2022
@jtracey93 jtracey93 merged commit 0e64799 into Azure:main Feb 28, 2022
@jtracey93 jtracey93 deleted the fix-153 branch February 28, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfaurskov jfaurskov jfaurskov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

❓👂 Question/Feedback - Explain when linter warnings should be disabled
2 participants
@jtracey93 @jfaurskov