Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample GitHub Action and Azure Pipeline to wiki #162

Merged
merged 23 commits into from
Feb 28, 2022
Merged

Add sample GitHub Action and Azure Pipeline to wiki #162

merged 23 commits into from
Feb 28, 2022

Conversation

ejhenry
Copy link
Contributor

@ejhenry ejhenry commented Feb 23, 2022

Overview/Summary

Add sample GitHub Action and Azure Pipeline code snippets to wiki and provide a brief overview of deployment orchestration.

This PR fixes/adds/changes/removes

  1. Adds wiki docs with pipeline overview and code snippets for GitHub Action and Azure Pipeline.

Breaking Changes

None

Testing Evidence

GitHub Action code snippet test results:
image

Azure Pipeline code snippet test results:
image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO 67617
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ejhenry ejhenry requested a review from jtracey93 February 23, 2022 20:03
@ejhenry ejhenry self-assigned this Feb 23, 2022
@jtracey93 jtracey93 requested a review from jfaurskov February 24, 2022 19:05
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a few small bits 👍

docs/wiki/PipelinesADO.md Outdated Show resolved Hide resolved
docs/wiki/PipelinesADO.md Show resolved Hide resolved
docs/wiki/PipelinesGitHub.md Show resolved Hide resolved
docs/wiki/PipelinesGitHub.md Outdated Show resolved Hide resolved
docs/wiki/PipelinesOverview.md Outdated Show resolved Hide resolved
docs/wiki/_Sidebar.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
docs/wiki/Home.md Show resolved Hide resolved
docs/wiki/Home.md Show resolved Hide resolved
Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we do a clear enough job of calling out that they should go through all parameters files before deploying? Agree with Jack's comments

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
@ghost ghost removed the Needs: Author Feedback label Feb 25, 2022
ejhenry and others added 7 commits February 25, 2022 10:12
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
@ejhenry
Copy link
Contributor Author

ejhenry commented Feb 25, 2022

Not sure if we do a clear enough job of calling out that they should go through all parameters files before deploying? Agree with Jack's comments

I'll make an explicit reference to updating the parameters files in the intro for each of the code samples.

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
jfaurskov
jfaurskov previously approved these changes Feb 28, 2022
@ejhenry ejhenry merged commit 48092cd into Azure:main Feb 28, 2022
@ejhenry ejhenry deleted the wiki-pipelines branch February 28, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants