-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled Virtual WAN scenario in a new vwanConnectivity module #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @faister, just a few bits, but nothing major 👍
Also do you think we should create another module like the Hub Networking but using VWAN instead?
Also do we need to update the Deployment Flow wiki page with an option here for VWAN or just a note?
infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep
Outdated
Show resolved
Hide resolved
infra-as-code/bicep/modules/vwanConnectivity/vwanConnectivity.bicep
Outdated
Show resolved
Hide resolved
Thanks @jtracey93
This is another module for VWAN, like hub networking.
Added another part in the Deployment Flow wiki to call out optional modules. Reason for calling this out as optional is because the VWAN networking scenario is rather niche for customers. But to get parity with ES repo, the next thing I could work on would be the orchestration to deploy a Contoso RI using ALZ Bicep modules. But that is dependent on the unstable orchestration issue which you are tracking with the PG. Have also enabled AZFW as a DNS proxy as per Azure/Enterprise-Scale#922 and test it out too. Part of this PR too. |
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…bicep Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…bicep Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…bicep Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…log-73009-vWANModule
…er/ALZ-Bicep into SEBacklog-73009-vWANModule
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…bicep Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…bicep Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…er/ALZ-Bicep into SEBacklog-73009-vWANModule
…bicep Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…er/ALZ-Bicep into SEBacklog-73009-vWANModule
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
…log-73009-vWANModule
…ore details in a separate section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few final pieces and I think we are there 👍
Nice work @faister
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Too easy, committed your changes. Are we good to approve and merge? Got some customers waiting for this :) |
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
Approving even though Link Check fails as this will exist once the PR has been merged as included with this PR |
Overview/Summary
This PR is an implementation of a module used to deploy the Virtual WAN network topology and its components according to the Azure Landing Zone conceptual architecture which can be found here.
This PR fixes/adds/changes/removes
Breaking Changes
None
Testing Evidence
Azure East US deployment evidence:
Resources deployed:
Overall deployment status:
vwanConnectivity deployment status:
VWAN overview:
Firewall policy:
Azure China deployment in China East 2evidence
Resources deployed:
Overall deployment status:
vwanConnectivity deployment status:
VWAN overview:
Firewall policy:
As part of this Pull Request I have
main
branch