Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Virtual WAN scenario in a new vwanConnectivity module #152

Merged
merged 44 commits into from
Mar 9, 2022

Conversation

faister
Copy link
Contributor

@faister faister commented Feb 16, 2022

Overview/Summary

This PR is an implementation of a module used to deploy the Virtual WAN network topology and its components according to the Azure Landing Zone conceptual architecture which can be found here.

This PR fixes/adds/changes/removes

  1. Implements vwanConnectivity module
  2. Resolves 💡 Feature Request - Enable Azure Virtual WAN scenario in the Hub Networking module #133
  3. Implements SE Backlog Item 73009
  4. Supports AZFW as a DNS proxy as per Add Firewall Policy resource for VWAN implementation Enterprise-Scale#922

Breaking Changes

None

Testing Evidence

Azure East US deployment evidence:

Resources deployed:
eastus-resourcedeployed

Overall deployment status:
eastus-overalldeploymentstatus

vwanConnectivity deployment status:
eastus-vwanconnectivitydeployment

VWAN overview:
eastus-vwanoverall

Firewall policy:
eastus-fwpolicies

Azure China deployment in China East 2evidence

Resources deployed:
chinaeast2-resourcedeployed

Overall deployment status:
chinaeast2-overalldeploymentstatus

vwanConnectivity deployment status:
chinaeast2-vwanconnectivitydeployment

VWAN overview:
chinaeast2-vwanoverall

Firewall policy:
chinaeast2-fwpolicies

As part of this Pull Request I have

@faister faister self-assigned this Feb 16, 2022
Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @faister, just a few bits, but nothing major 👍

Also do you think we should create another module like the Hub Networking but using VWAN instead?

Also do we need to update the Deployment Flow wiki page with an option here for VWAN or just a note?

infra-as-code/bicep/modules/vwanConnectivity/README.md Outdated Show resolved Hide resolved
infra-as-code/bicep/modules/vwanConnectivity/README.md Outdated Show resolved Hide resolved
infra-as-code/bicep/modules/vwanConnectivity/README.md Outdated Show resolved Hide resolved
infra-as-code/bicep/modules/vwanConnectivity/README.md Outdated Show resolved Hide resolved
infra-as-code/bicep/modules/vwanConnectivity/README.md Outdated Show resolved Hide resolved
@faister
Copy link
Contributor Author

faister commented Feb 23, 2022

Nice work @faister Fai Lai FTE, just a few bits, but nothing major 👍

Thanks @jtracey93

Also do you think we should create another module like the Hub Networking but using VWAN instead?

This is another module for VWAN, like hub networking.

Also do we need to update the Deployment Flow wiki page with an option here for VWAN or just a note?

Added another part in the Deployment Flow wiki to call out optional modules. Reason for calling this out as optional is because the VWAN networking scenario is rather niche for customers.

But to get parity with ES repo, the next thing I could work on would be the orchestration to deploy a Contoso RI using ALZ Bicep modules. But that is dependent on the unstable orchestration issue which you are tracking with the PG.

Have also enabled AZFW as a DNS proxy as per Azure/Enterprise-Scale#922 and test it out too. Part of this PR too.

faister and others added 18 commits February 23, 2022 13:08
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
…bicep

Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
@faister faister requested review from jfaurskov and jtracey93 March 4, 2022 03:51
@jfaurskov
Copy link
Contributor

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfaurskov
Copy link
Contributor

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfaurskov
Copy link
Contributor

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@jtracey93 jtracey93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few final pieces and I think we are there 👍

Nice work @faister

docs/wiki/DeploymentFlow.md Outdated Show resolved Hide resolved
docs/wiki/DeploymentFlow.md Outdated Show resolved Hide resolved
docs/wiki/DeploymentFlowHS.md Outdated Show resolved Hide resolved
docs/wiki/DeploymentFlowHS.md Outdated Show resolved Hide resolved
docs/wiki/DeploymentFlowVWAN.md Outdated Show resolved Hide resolved
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
@ghost ghost removed the Needs: Author Feedback label Mar 8, 2022
faister and others added 4 commits March 9, 2022 09:57
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
Co-authored-by: Jack Tracey <41163455+jtracey93@users.noreply.github.com>
@faister
Copy link
Contributor Author

faister commented Mar 8, 2022

A few final pieces and I think we are there 👍

Nice work @faister Fai Lai FTE

Too easy, committed your changes. Are we good to approve and merge? Got some customers waiting for this :)

@jtracey93
Copy link
Collaborator

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93
Copy link
Collaborator

Approving even though Link Check fails as this will exist once the PR has been merged as included with this PR

@jtracey93 jtracey93 merged commit 40f1271 into Azure:main Mar 9, 2022
@jtracey93 jtracey93 mentioned this pull request Mar 21, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 Feature Request - Enable Azure Virtual WAN scenario in the Hub Networking module
3 participants