Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Missing Parameters from Parameters File for Hub Networking #136

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

jtracey93
Copy link
Collaborator

Overview/Summary

Fixes missing parameters raised from #132 in hub networking parameters file.

Fixes #132

This PR fixes/adds/changes/removes

  1. Add missing parameters to hubNetworking.parameters.example.json
    • parNetworkDNSEnableProxy
    • parDisableBGPRoutePropagation
  2. Update docs for module and param descriptions

Breaking Changes

None

Testing Evidence

No changes to default values already so linting and unit tests will suffice.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jtracey93 jtracey93 temporarily deployed to BicepUnitTests February 8, 2022 21:43 Inactive
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Feb 8, 2022
@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label Feb 8, 2022
@jtracey93 jtracey93 requested a review from jfaurskov February 8, 2022 22:12
@jtracey93 jtracey93 temporarily deployed to BicepUnitTests February 8, 2022 22:22 Inactive
@jtracey93 jtracey93 merged commit 8ebf356 into main Feb 9, 2022
@jtracey93 jtracey93 deleted the fix-132 branch February 11, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 Minor Bug Report - Inconsistent declaration & documentation of parameters in Hub Networking module
2 participants